Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt+click(mac)/ctrl+click(win/linux) on terminal + panel action should split active terminal #43877

Closed
Tyriar opened this issue Feb 17, 2018 · 1 comment
Closed

Alt+click(mac)/ctrl+click(win/linux) on terminal + panel action should split active terminal #43877

Tyriar opened this issue Feb 17, 2018 · 1 comment
Assignees
@isidorn
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 17, 2018

This was a suggestion from @isidorn, forking off from #7504
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Feb 17, 2018
@Tyriar Tyriar added this to the February 2018 milestone Feb 17, 2018
@Tyriar Tyriar mentioned this issue Feb 17, 2018
Closed
@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2018

@Tyriar sorry for the slow response, this somehow fall under my radar.
I pushed the change, it works nicely. However feel free to restructure my commit as I might have forgot about some corner case. My commit is basicaly an examply how to do it :)

@isidorn isidorn added the verification-needed Verification of issue is requested label Feb 26, 2018
isidorn added a commit that referenced this issue Feb 26, 2018
@isidorn
better instanceof check
8f9fdee 
fixes #43877
@sandy081 sandy081 added the verified Verification succeeded label Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@isidorn @Tyriar @sandy081