Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm save changes prompt should switch to corresponding editor to set context #39430

Closed
auchenberg opened this issue Dec 1, 2017 · 2 comments
Closed

Confirm save changes prompt should switch to corresponding editor to set context #39430

auchenberg opened this issue Dec 1, 2017 · 2 comments
Assignees
@bpasero
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window

Comments

@auchenberg
Copy link
Contributor

This is opened for this Twitter thread: https://mobile.twitter.com/_munter_/status/936653730816151552

The attention to detail in Sublime Text is still far beyond VS Code. E.g. this is closing multiple unsaved documents. VS Code thinks Untitled is a helpful name and that I don't need to see the content to know whether to save.

dp-d2fmuqaaxhdy

dp-d2fmvoaaw97r

Expected:
I didn't make the point clear. It's that Sublime switches the active tab. The filename is just extra unclear.
@vscodebot vscodebot bot added workbench workbench-tabs VS Code editor tab issues labels Dec 1, 2017
@bpasero bpasero added workbench-editors Managing of editor widgets in workbench window feature-request Request for new features or functionality and removed workbench workbench-tabs VS Code editor tab issues labels Dec 3, 2017
bpasero added a commit that referenced this issue Dec 3, 2017
@bpasero
Confirm save changes prompt should switch to corresponding editor to …
5ae37d8 
…set context (fixes #39430)
@bpasero
Copy link
Member

bpasero commented Dec 4, 2017

/duplicate #17552

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 4, 2017
@vscodebot
Copy link

vscodebot bot commented Dec 4, 2017

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Dec 4, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auchenberg @bpasero