Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM icons look like they have different sizes #37530

Closed
bpasero opened this issue Nov 2, 2017 · 3 comments
Closed

SCM icons look like they have different sizes #37530

bpasero opened this issue Nov 2, 2017 · 3 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone
November 2017

Comments

@bpasero
Copy link
Member

bpasero commented Nov 2, 2017 •
edited
Loading

Looks unbalanced (especially the discard again vs. the stage action):

image
@joaomoreno joaomoreno added this to the November 2017 milestone Nov 6, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Nov 6, 2017
Dozed12 pushed a commit to Dozed12/vscode that referenced this issue Nov 22, 2017
Size down SCM discard icon
bd642e3 
microsoft#37530
@Dozed12 Dozed12 mentioned this issue Nov 25, 2017
Merged
@bpasero
Copy link
Member Author

bpasero commented Dec 1, 2017

While this might have fixed the icon issue in the quick diff area, now I find it uneven in the changes view where icons are typically 16px:

image

@joaomoreno
Copy link
Member

This is the before/after. The after does look better:

img

@bpasero
Copy link
Member Author

bpasero commented Dec 1, 2017

Yeah looks good for you. Might be my zoom level of 2 then.

@bpasero bpasero added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@joaomoreno @bpasero