Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently opened files is just a bucket and not sorted by recency #31591

Closed
jrieken opened this issue Jul 27, 2017 · 4 comments
Closed

Recently opened files is just a bucket and not sorted by recency #31591

jrieken opened this issue Jul 27, 2017 · 4 comments
Assignees
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jul 27, 2017

I have a multi-root workspace with the vscode-sources and an extension (called 'virtual'). Both folders have vscode.d.ts and while I surely have opened both files at least once, I have opened vscode.d.ts from the vscode-sources at least 1000-times more often (and more recent). Still, the file picker presents the vscode.d.ts from the extension on top, always. It seems like I once made a mistake to open the wrong vscode.d.ts-file and I am still being punished for that.

screen shot 2017-07-27 at 17 12 07

@bpasero
Copy link
Member

bpasero commented Aug 11, 2017

@jrieken if you now select the vscode.d.ts from the vscode folder and bring up the picker again, you are not seeing the one from vscode first? The sorting is strictly done via most recently used and using the resource URI as key, so please check.

@bpasero bpasero added this to the August 2017 milestone Aug 11, 2017
@bpasero bpasero added the info-needed Issue requires more information from poster label Aug 11, 2017
@bpasero
Copy link
Member

bpasero commented Aug 11, 2017

@jrieken I think I see what happens, you are starting to search and in that case the sorting order of the "recently opened" section is no longer by recency but using a similar matching and sorting as we have for the file results below. In this case it seems the shorter path is just winning over the longer one.

One way of getting rid of the result is to trigger the "Remove From History" command and pick the file you want to remove. It will not help though if you ever open it again:

image

@jrieken
Copy link
Member Author

jrieken commented Aug 14, 2017

In this case it seems the shorter path is just winning over the longer one.

For IntelliSense matching length is only penalised between the first and last matching character, not on the ratio of covered characters. That usually yields much better results

@bpasero bpasero removed the info-needed Issue requires more information from poster label Aug 16, 2017
@bpasero bpasero modified the milestones: August 2017, On Deck Aug 16, 2017
@bpasero bpasero modified the milestones: Backlog, On Deck Aug 31, 2017
@bpasero bpasero modified the milestones: Backlog, October 2017 Oct 4, 2017
@bpasero
Copy link
Member

bpasero commented Oct 4, 2017

I am now sorting by recency of items in this bucket if the score of the elements are identical instead of sorting by path length.

@bpasero bpasero closed this as completed Oct 4, 2017
bpasero added a commit that referenced this issue Oct 4, 2017
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants