Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish node2 with localizations #30458

Closed
roblourens opened this issue Jul 12, 2017 · 1 comment
Closed

Publish node2 with localizations #30458

roblourens opened this issue Jul 12, 2017 · 1 comment
Assignees
@roblourens
Labels
candidate Issue identified as probable candidate for fixing in the next release debug Debug viewlet, configurations, breakpoints, adapter issues l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone
June Recovery 2017

Comments

@roblourens
Copy link
Member

Didn't quite get these in time for 1.14...
@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues l10n-platform Localization platform issues (not wrong translations) labels Jul 12, 2017
@roblourens roblourens added this to the June Recovery 2017 milestone Jul 12, 2017
@roblourens roblourens self-assigned this Jul 12, 2017
@roblourens roblourens added the candidate Issue identified as probable candidate for fixing in the next release label Jul 12, 2017
roblourens added a commit that referenced this issue Jul 12, 2017
@roblourens
node-debug2@1.14.5 - fix #30458
b900047
roblourens added a commit that referenced this issue Jul 12, 2017
@roblourens
node-debug2@1.14.5 - fix #30458
e4b90c2
@roblourens
Copy link
Member Author

Verification - debug with "protocol": "inspector", and trigger an error. For example, have an "attach" config with "port": 1234 when nothing is running on that port. Check that the message is localized. Not all messages are localized yet.

@kieferrm kieferrm added the verified Verification succeeded label Jul 13, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
candidate Issue identified as probable candidate for fixing in the next release debug Debug viewlet, configurations, breakpoints, adapter issues l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Milestone
June Recovery 2017
Development

No branches or pull requests
2 participants
@roblourens @kieferrm