Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text disappeared after update to 1.13 [Bug] #28619

Closed
tonoslav opened this issue Jun 13, 2017 · 13 comments · Fixed by #96948
Closed

Text disappeared after update to 1.13 [Bug] #28619

tonoslav opened this issue Jun 13, 2017 · 13 comments · Fixed by #96948
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release
Milestone
May Recovery 2017

Comments

@tonoslav
Copy link

tonoslav commented Jun 13, 2017 •
edited
Loading

  • VSCode Version: 1.13
  • OS Version: Windows 10.0.14393

Steps to Reproduce:

  1. Updated to 1.13
  2. Nothing else

screenshot_1

Update

Insider version is the same

Update 2

Downgrade to 12.2 fixed the problem

Update 3

Problem is with font-family: system-ui , how to fix it?
@ramya-rao-a
Copy link
Contributor

@tonoslav Whe you say "Insider version is the same", do you mean that you see the issue in Insiders as well or Insiders works as expected and is same as before ?

@bpasero
Copy link
Member

bpasero commented Jun 14, 2017 •
edited
Loading

@tonoslav this could be due to us changing the default font in 1.13 for the workbench. Can you open the dev tools (from the help menu) and find the monaco-shell CSS class font-family:

image

Change this to "Arial" or "Times New Roman", does the text show up?

What are your OS font settings?

/cc @jhasse @Tyriar

@bpasero bpasero added the info-needed Issue requires more information from poster label Jun 14, 2017
@bpasero bpasero added this to the June 2017 milestone Jun 14, 2017
@jhasse
Copy link
Contributor

jhasse commented Jun 14, 2017

Could also be some caching problem. Try to delete %AppData%\Code\Cache and %AppData%\Code\CachedData while VSCode isn't running and start it again.

The font should be the same as the one for File, Edit, etc. (which does show up). But maybe it's using a different glyph cache or something?

@tonoslav
Copy link
Author

@ramya-rao-a yeah I meant that it doesnt matter if I use normal VSCode or Insider version

@jhasse Cache clear didnt help

@bpasero I have found out that the problem is with Font-family: system-ui when I delete system-ui from fonts in developer tools, it works, how can I fix this in general?

I have found out I have this problem with system-ui font everywhere in all chromium like browsers I think, firefox for example works ok when I see website with font-family: system-ui

@jhasse
Copy link
Contributor

jhasse commented Jun 14, 2017

I have found out I have this problem with system-ui font everywhere in all chromium like browsers

That's very good to know! Can you reproduce it here? https://jsfiddle.net/9yeoLewo/
I've created a Chromium bug report, maybe someone from the developers can comment on this problem: https://bugs.chromium.org/p/chromium/issues/detail?id=733219

firefox for example works ok when I see website with font-family: system-ui

Firefox doesn't support system-ui (it's an alias for the default system font).

@bpasero
Copy link
Member

bpasero commented Jun 14, 2017 •
edited
Loading

Given this bug I think we need to revert the change to use system-ui until Chrome fixed this issue. It looks like the fallback is not applied, so there does not seem to be a workaround.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 14, 2017
@jhasse
Copy link
Contributor

jhasse commented Jun 14, 2017

Yes, you should be able to revert 663608d and then 45d93e9.

@tonoslav
Copy link
Author

@jhasse @bpasero So what should I do? Should I replace some files by myself or what? Thx

@jhasse
Copy link
Contributor

jhasse commented Jun 14, 2017

That's a possibility, although VS Code will then complain, that your installation seems to be corrupted.
I would stick with 1.12 for the time being.

Can you reproduce the problem here? https://jsfiddle.net/9yeoLewo/

Also: Do you have any unusable font settings enabled?

@tonoslav
Copy link
Author

@jhasse

  1. yes I can reproduce it there
  2. No I don't have any unusable font settings

Btw does this means that everybody has the same problem, or why I have and some don't?

@jhasse
Copy link
Contributor

jhasse commented Jun 14, 2017

So far it seems that you're the only one with the problem. I can't reproduce it on Windows 10 and system-ui was enabled for the Insiders version for some time.

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2017

So far it seems that you're the only one with the problem.

I think I saw this reported one other time, might have been on Twitter.

@bpasero bpasero mentioned this issue Jun 14, 2017
Closed
@bpasero
Copy link
Member

bpasero commented Jun 14, 2017

Reverted.

@ramya-rao-a ramya-rao-a added the candidate Issue identified as probable candidate for fixing in the next release label Jun 14, 2017
ramya-rao-a pushed a commit that referenced this issue Jun 14, 2017
@bpasero @ramya-rao-a
Text disappeared after update to 1.13 [Bug] (fixes #28619)
379d2ef
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
bpasero pushed a commit that referenced this issue May 8, 2020
@kdrag0n
Use system-ui alias for UI fonts (fixes #10144) (#96948)
ff11834 
Commit 45d93e9 applied this change in
some areas, but it was reverted to fix #28619. The underlying cause of
the regression was Chromium bug 733219 [1], which has now been fixed, so
this change should be safe to apply now.

The old font stacks have been kept with lower priorities to work around
Chromium bug 724393 [2].

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=733219
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=724393
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
May Recovery 2017
Development

Successfully merging a pull request may close this issue.

Use system-ui alias for UI fonts (fixes #10144)
6 participants
@jhasse @bpasero @Tyriar @tonoslav @chrmarti @ramya-rao-a