use '--inspect-brk' instead of '--debug-brk' when connecting to node v8

[weinand]

[roblourens]

#27597 for now.

This combination of args is the only way to enter debug mode across all node versions. At some point I'll switch to inspect-brk if we don't want to support node 6.x anymore, or will do version detection for it and do something for runtimeExecutable scenarios.

[roblourens]

All I have to do is copy the version detection code from node-debug, and use the old flags when runtimeExecutable is set. I just don't want to change it this late in the month.

There are now far more people using node2 with node 8 than node 6, this needs to be fixed...

[weinand]

The latest node-debug extension (available in the frozen Insiders) passes the version string (e.g. "v7.9.0") as a property __nodeVersion to the DAs whenever it had probed for the version by running node --version.

[roblourens]

Thanks! However I realized that I still need to test even when node-debug doesn't do version detection, like when "protocol": "inspector" is set.

[Deilan]

Still having the warning as of Node 8.7.0 and VS Code 1.17.1:

Debugger listening on ws://127.0.0.1:23988/5b5294e3-fe2b-4f1c-9045-1998fd739672
For help see https://nodejs.org/en/docs/inspector
Debugger attached.
(node:6044) [DEP0062] DeprecationWarning: `node --inspect --debug-brk` is deprecated. Please use `node --inspect-brk` instead.

[nicemaker]

works for me with latest node and latest visual studio, running debug mode via npm. I use nodemon to track file changes.

In package.json:

scripts:{
"debug": "DEBUG=pd* nodemon --inspect-brk --harmony --nolazy server.js -e js,mustache,json,yaml"
}

I run debug script via terminal, always running in background and restarting automatically on file changes. Make sure you use --inspect-brk.

Then default debug launch configuration for node from latest VS Code:

{  "type": "node",
    "request": "attach",
    "name": "Attach",
    "port": 9229
}