Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Do not use "--debug-brk" if a runtimeExecutable is specified #121

Closed
weinand opened this issue Jul 13, 2017 · 1 comment
Closed

Do not use "--debug-brk" if a runtimeExecutable is specified #121

weinand opened this issue Jul 13, 2017 · 1 comment
Assignees

Comments

@weinand
Copy link
Contributor

weinand commented Jul 13, 2017

Currently node-debug2 passes a combination of "--inspect" and "--debug-brk" flags when launching node.js (and any other "runtimeExecutable"). This is done because node.js versions < v8.0 do not support "--inspect-brk" but instead the combination only).

Since I'm not sure that Electron (or other runtimeExecutables) will support this combination too, I suggest that we stop using the combination whenever a runtimeExecutable is specified.

Does this make sense?

See microsoft/vscode#30504 (comment)

@roblourens
Copy link
Member

I just put microsoft/vscode#27731 on the July milestone, I'll track it there.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants