Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to configure a window (also for reload case)? #27192

Closed
alexdima opened this issue May 24, 2017 · 2 comments
Closed

How to configure a window (also for reload case)? #27192

alexdima opened this issue May 24, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented May 24, 2017

Possible root cause for #26506

  • run scripts\code.bat and open an editor
  • observe the window shows Ln, Col information in the status bar:
    image
  • start VoiceOver or NVDA and move the cursor in the editor
  • observe the window detects a screen reader is attached and no longer shows the Ln, Col information in the status bar:
    image

Press ctrl+r: Observe the screen reader is no longer detected

I believe this has to do with how we create the window in the main process and how we pass configuration options to the window.

I have the same code path for accessibilitySupportEnabled as for isISOKeyboard -- we wrote this together, but it appears this is not functioning correctly for the reload window case. What else is needed to get the reload case working too?

@alexdima alexdima added this to the May 2017 milestone May 24, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label May 24, 2017
@bpasero
Copy link
Member

bpasero commented May 24, 2017

@alexandrudima cool that could be an explanation for the keybinding weirdness I have been seeing, will have to check in the code to know what we do special on reload. I think we manually copy some settings over (https://github.com/Microsoft/vscode/blob/master/src/vs/code/electron-main/window.ts#L531 is suspicious)

@alexdima
Copy link
Member Author

Nice! ❤️

@roblourens roblourens added the verified Verification succeeded label Jun 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants