Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug pauses, callstack not available #24348

Closed
Eli-Goldberg opened this issue Apr 9, 2017 · 12 comments
Closed

Debug pauses, callstack not available #24348

Eli-Goldberg opened this issue Apr 9, 2017 · 12 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@Eli-Goldberg
Copy link

Eli-Goldberg commented Apr 9, 2017

  • VSCode Version:
    Version 1.12.0-insider
    Commit 77df764
    Date 2017-04-07T06:09:22.690Z

  • OS Version: Ubuntu 16.04

  • Debug protocol: "Auto (inspect, Node 7.7.1)"

image

Steps to Reproduce:

  1. Put a breakpoint somewhere,
  2. Debug, get to the breakpoint
  3. Press F5 - debug will freeze and callstack will show "Callstack not available"
@Eli-Goldberg
Copy link
Author

I had some code with the "co" library, lot's of generator and promises,
if it's any help

@chrmarti
Copy link
Collaborator

Could you post a simple code example that reproduces the problem?

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Apr 10, 2017
@weinand
Copy link
Contributor

weinand commented Apr 10, 2017

@Eli-Goldberg does it make a difference if you set the "protocol" to "inspector"?

@Eli-Goldberg
Copy link
Author

@weinand I'm pretty sure it doesn't matter because setting protocol to "auto" runs with inspect since it's node 7.7.1 but I can check.
@chrmarti
will post a simple example in ~24 hours.
I'm pretty sure it has to do with almost no free RAM (lot's of data is loaded into memory sent via http).

@weinand
Copy link
Contributor

weinand commented Apr 10, 2017

@Eli-Goldberg in VS Code 1.12.0 "inspect" is only used for node >= 8.0.
see https://code.visualstudio.com/updates/v1_11#_node-debugging

@weinand
Copy link
Contributor

weinand commented Apr 10, 2017

With the old "legacy" protocol, the node debugger of VS Code will most likely run into callstack timeouts if there are big data structures kept in local variables or passed as parameters.

@Eli-Goldberg
Copy link
Author

@weinand Thanks that's right, the tooltip got me confused:
image

I will do the check with inspector.

@weinand
Copy link
Contributor

weinand commented Apr 10, 2017

Yes, that's a bit confusing: node >= 6.3 already supports the new protocol but we are only auto detecting it for versions >= 8.0.

/cc @roblourens

@Eli-Goldberg
Copy link
Author

So the original problem does not happen here, but another issue is happening:
First - these errors:
image
Also,
If I remove breakpoints (remove all breakpoints), the code still stops where I previously had the breakpoints.

@roblourens
Copy link
Member

That is due to an unfortunate Node bug, nodejs/node#11589, which I think should be fixed in Node 7.8. I don't think it should continue stopping there after removing breakpoints, but I guess it would be part of the same issue.

Regarding the fact that 'auto' only uses inspector for v8+, that's a good point. Maybe the label of 'auto' should reflect this...

roblourens added a commit to microsoft/vscode-node-debug that referenced this issue Apr 11, 2017
@Eli-Goldberg
Copy link
Author

@roblourens
This indeed does look fixed in node 7.9.0 (probably in 7.8.0 too),
Can't reproduce it.
Also, I'm afraid I can't provide a code sample that reproduces this on earlier node versions.

@roblourens
Copy link
Member

Glad that worked. I think we can close this issue then right?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

4 participants