Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mandatory signature verification in Linux #239579

Open
sandy081 opened this issue Feb 4, 2025 · 2 comments · Fixed by #239580
Open

Enable mandatory signature verification in Linux #239579

sandy081 opened this issue Feb 4, 2025 · 2 comments · Fixed by #239580
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Feb 4, 2025

Enable signature verification blocking in Linux

@sandy081 sandy081 added extensions Issues concerning extensions feature-request Request for new features or functionality labels Feb 4, 2025
@sandy081 sandy081 added this to the February 2025 milestone Feb 4, 2025
@sandy081 sandy081 self-assigned this Feb 4, 2025
sandy081 added a commit that referenced this issue Feb 4, 2025
@sandy081 sandy081 mentioned this issue Feb 4, 2025
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 4, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 6, 2025
@sandy081
Copy link
Member Author

@furai is seeing following after enabling mandatory signature verification in Linux

Yeah, I'm getting this right now on latest insiders for 2 currently outdated extensions from Microsoft:

  • GitHub.copilot-chat
  • ms-python.python

Image

Version: 1.98.0-insider
Commit: edd39c48ec3c81b5f8c6ddf1893a95acf8662187
Date: 2025-02-06T05:04:30.184Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Linux x64 6.13.1-arch1-1

@furai Can you please try to reproduce the issue by following these steps:

  • Enable Log Level to Trace F1 > Developer: Set Log Level > Trace
  • Reproduce the Issue
  • Share the log - F1 > Open View... > Shared

Can you please let us know how you installed VS Code Insiders on your machine?

@sandy081 sandy081 reopened this Feb 10, 2025
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Feb 10, 2025
@furai
Copy link

furai commented Feb 13, 2025

@sandy081 I hope this is enough in terms of logs. It should be everything from clicking on update button to when it fails.
I've installed it using AUR on Arch Linux which in turn is using .deb file. So it's not flatpack version or anything like this.

Logs

2025-02-13 08:08:57.279 [trace] [Network] #80: https://GitHub.gallery.vsassets.io/_apis/public/gallery/publisher/GitHub/extension/copilot/1.270.1374/assetbyname/Microsoft.VisualStudio.Code.Manifest - begin GET {"X-Market-Client-Id":"VSCode 1.98.0-insider","User-Agent":"VSCode 1.98.0-insider (Code - Insiders)"}
2025-02-13 08:08:57.279 [info] [Shared] Getting Manifest... github.copilot
2025-02-13 08:08:57.555 [trace] [Network] #80: https://GitHub.gallery.vsassets.io/_apis/public/gallery/publisher/GitHub/extension/copilot/1.270.1374/assetbyname/Microsoft.VisualStudio.Code.Manifest - end GET 200 {"access-control-allow-origin":"*","access-control-expose-headers":"x-ms-request-id,Server,x-ms-version,Content-Type,Content-Encoding,Cache-Control,Last-Modified,ETag,x-ms-lease-status,x-ms-blob-type,Content-Length,Date,Transfer-Encoding","cache-control":"public, max-age=31536000","connection":"keep-alive","content-encoding":"gzip","content-length":"4424","content-type":"application/json","date":"Thu, 13 Feb 2025 07:08:57 GMT","etag":"0x8DD4BCEA1FC4EF4","last-modified":"Thu, 13 Feb 2025 01:35:00 GMT","vary":"Accept-Encoding","x-ms-blob-type":"BlockBlob","x-ms-lease-status":"unlocked","x-ms-request-id":"81dc1f82-501e-0078-7cb8-7d64f7000000","x-ms-version":"2009-09-19"}
2025-02-13 08:08:57.556 [info] [Shared] Installing extension: github.copilot {"installPreReleaseVersion":true,"pinned":false,"productVersion":{"version":"1.98.0-insider","date":"2025-02-12T16:16:25.911Z"},"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:[redacted].vscode-insiders/extensions/extensions.json","path":"[redacted].vscode-insiders/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2025-02-13 08:08:57.556 [trace] [Shared] Started scanning system extensions
2025-02-13 08:08:57.556 [trace] [Shared] Started scanning user extensions {"$mid":1,"external":"vscode-userdata:[redacted].vscode-insiders/extensions/extensions.json","path":"[redacted].vscode-insiders/extensions/extensions.json","scheme":"vscode-userdata"}
2025-02-13 08:08:57.564 [debug] [Shared] Using cached extensions scan result system file:///opt/visual-studio-code-insiders/resources/app/extensions
2025-02-13 08:08:57.564 [trace] [Shared] Scanned system extensions: 90
2025-02-13 08:08:57.589 [trace] [Shared] Scanned user extensions: 74
2025-02-13 08:08:57.589 [debug] [Shared] Skipping extension [redacted].vscode-insiders/extensions/ms-vscode.js-debug-1.72.1 with lower version 1.72.1 in favour of /opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug with version 1.97.1
2025-02-13 08:08:57.595 [trace] [Shared] Started scanning system extensions
2025-02-13 08:08:57.595 [trace] [Shared] Started scanning user extensions {"$mid":1,"external":"vscode-userdata:[redacted].vscode-insiders/extensions/extensions.json","path":"[redacted].vscode-insiders/extensions/extensions.json","scheme":"vscode-userdata"}
2025-02-13 08:08:57.602 [debug] [Shared] Using cached extensions scan result system file:///opt/visual-studio-code-insiders/resources/app/extensions
2025-02-13 08:08:57.602 [trace] [Shared] Scanned system extensions: 90
2025-02-13 08:08:57.621 [trace] [Shared] Scanned user extensions: 74
2025-02-13 08:08:57.621 [debug] [Shared] Skipping extension [redacted].vscode-insiders/extensions/ms-vscode.js-debug-1.72.1 with lower version 1.72.1 in favour of /opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug with version 1.97.1
2025-02-13 08:08:57.627 [trace] [Shared] Started scanning user extensions {"$mid":1,"external":"vscode-userdata:[redacted].vscode-insiders/extensions/extensions.json","path":"[redacted].vscode-insiders/extensions/extensions.json","scheme":"vscode-userdata"}
2025-02-13 08:08:57.646 [trace] [Shared] Scanned user extensions: 74
2025-02-13 08:08:57.655 [trace] [Shared] [File Watcher (node.js)] [raw] ["change"] .obsolete
2025-02-13 08:08:57.655 [trace] [Shared] [File Watcher (node.js)] [CHANGED] [redacted].vscode-insiders/extensions/.obsolete
2025-02-13 08:08:57.655 [trace] [Shared] [File Watcher (node.js)] [raw] ["change"] .obsolete
2025-02-13 08:08:57.656 [trace] [Shared] [File Watcher (node.js)] [CHANGED] [redacted].vscode-insiders/extensions/.obsolete
2025-02-13 08:08:57.667 [trace] [Network] resolveShellEnv(): skipped (VSCODE_CLI is set)
2025-02-13 08:08:57.667 [trace] [Network] #81: https://GitHub.gallerycdn.vsassets.io/extensions/github/copilot/1.270.1374/1739410497738/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&update=true - begin GET {"X-Market-Client-Id":"VSCode 1.98.0-insider","User-Agent":"VSCode 1.98.0-insider (Code - Insiders)"}
2025-02-13 08:08:57.667 [trace] [Shared] ExtensionGalleryService#download github.copilot
2025-02-13 08:08:57.729 [debug] [Shared] User data changed
2025-02-13 08:08:57.730 [trace] [Shared] [File Watcher (node.js)]  >> normalized [CHANGED] [redacted].vscode-insiders/extensions/.obsolete
2025-02-13 08:08:57.881 [trace] [Network] #81: https://GitHub.gallerycdn.vsassets.io/extensions/github/copilot/1.270.1374/1739410497738/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&update=true - end GET 200 {"access-control-allow-origin":"*","access-control-expose-headers":"x-ms-request-id,Server,x-ms-version,Content-Type,Cache-Control,Last-Modified,ETag,x-ms-lease-status,x-ms-blob-type,Content-Length,Date,Transfer-Encoding","cache-control":"public, max-age=31536000","connection":"keep-alive","content-length":"15628362","content-type":"application/zip","date":"Thu, 13 Feb 2025 07:08:57 GMT","etag":"0x8DD4BCEA13B654B","last-modified":"Thu, 13 Feb 2025 01:34:59 GMT","x-ms-blob-type":"BlockBlob","x-ms-lease-status":"unlocked","x-ms-request-id":"30e6be87-701e-00b1-42b8-7dfff0000000","x-ms-version":"2009-09-19"}
2025-02-13 08:08:58.538 [trace] [Network] resolveShellEnv(): skipped (VSCODE_CLI is set)
2025-02-13 08:08:58.538 [trace] [Network] #82: https://GitHub.gallery.vsassets.io/_apis/public/gallery/publisher/GitHub/extension/copilot/1.270.1374/assetbyname/Microsoft.VisualStudio.Services.VsixSignature - begin GET {"X-Market-Client-Id":"VSCode 1.98.0-insider","User-Agent":"VSCode 1.98.0-insider (Code - Insiders)"}
2025-02-13 08:08:58.538 [trace] [Shared] ExtensionGalleryService#downloadSignatureArchive github.copilot
2025-02-13 08:08:58.837 [trace] [Network] #82: https://GitHub.gallery.vsassets.io/_apis/public/gallery/publisher/GitHub/extension/copilot/1.270.1374/assetbyname/Microsoft.VisualStudio.Services.VsixSignature - end GET 200 {"access-control-allow-origin":"*","access-control-expose-headers":"x-ms-request-id,Server,x-ms-version,Content-Type,Cache-Control,Last-Modified,ETag,x-ms-lease-status,x-ms-blob-type,Content-Length,Date,Transfer-Encoding","cache-control":"public, max-age=31536000","connection":"keep-alive","content-length":"12306","content-type":"application/zip","date":"Thu, 13 Feb 2025 07:08:58 GMT","etag":"0x8DD4BCF59967D40","last-modified":"Thu, 13 Feb 2025 01:40:08 GMT","x-ms-blob-type":"BlockBlob","x-ms-lease-status":"unlocked","x-ms-request-id":"247d7f45-e01e-000f-07b8-7db163000000","x-ms-version":"2009-09-19"}
2025-02-13 08:08:58.845 [trace] [Shared] Verifying extension signature for github.copilot...
2025-02-13 08:08:58.846 [info] [Shared] Extension signature verification result for github.copilot: UnknownError. Executed: true. Duration: 6ms.
2025-02-13 08:08:58.847 [trace] [Shared] Extension signature verification output for github.copilot:

2025-02-13 08:08:58.850 [error] [Shared] Error while installing the extension github.copilot Signature verification failed with 'UnknownError' error. vscode-userdata:[redacted].vscode-insiders/extensions/extensions.json
2025-02-13 08:08:58.850 [error] [Shared] [uncaught exception in sharedProcess]: Signature verification failed with 'UnknownError' error.: SignatureVerificationInternal: Signature verification failed with 'UnknownError' error.
    at uh.ub (file:///opt/visual-studio-code-insiders/resources/app/out/vs/code/electron-utility/sharedProcess/sharedProcessMain.js:74:63762)
    at async uh.tb (file:///opt/visual-studio-code-insiders/resources/app/out/vs/code/electron-utility/sharedProcess/sharedProcessMain.js:74:62340)
2025-02-13 08:09:01.200 [trace] [Network] resolveShellEnv(): skipped (VSCODE_CLI is set)
2025-02-13 08:09:01.201 [trace] [Network] #83: https://vscode-sync-insiders.trafficmanager.net/v1/manifest - begin GET {"X-Execution-Id":"03a668c4-adba-4936-a516-3206835c40e4","Content-Type":"application/json","If-None-Match":"W/\"1a0-ikU6ScC0BGLhthJo53AlJkZpJNw\"","X-Client-Name":"code-insiders","X-Client-Version":"1.98.0-insider","X-Client-Commit":"29ad3d06bde55ac2ed93599d63ae955778485cdb","X-Account-Type":"github","authorization":"*****","X-Machine-Session-Id":"2273c4e1-6914-4544-a1a9-3fefd28083bc","X-User-Session-Id":"c7a2593e-8503-4e4a-9b5d-b74a1d76f5c9"}
2025-02-13 08:09:01.266 [trace] [Network] #83: https://vscode-sync-insiders.trafficmanager.net/v1/manifest - end GET 304 {"access-control-expose-headers":"etag","date":"Thu, 13 Feb 2025 07:09:01 GMT","etag":"W/\"1a0-ikU6ScC0BGLhthJo53AlJkZpJNw\"","request-context":"appId=cid-v1:30ca13eb-88b0-4b5c-b90a-954f04395628","strict-transport-security":"max-age=31536000","vary":"Origin","x-content-type-options":"nosniff","x-operation-id":"2ebb2fbe694c416eb097e0a5c267a5f2"}
2025-02-13 08:09:01.302 [trace] [Shared] Started scanning system extensions
2025-02-13 08:09:01.302 [trace] [Shared] Started scanning user extensions {"$mid":1,"external":"vscode-userdata:[redacted].vscode-insiders/extensions/extensions.json","path":"[redacted].vscode-insiders/extensions/extensions.json","scheme":"vscode-userdata"}
2025-02-13 08:09:01.310 [debug] [Shared] Using cached extensions scan result system file:///opt/visual-studio-code-insiders/resources/app/extensions
2025-02-13 08:09:01.310 [trace] [Shared] Scanned system extensions: 90
2025-02-13 08:09:01.333 [trace] [Shared] Scanned user extensions: 74
2025-02-13 08:09:01.334 [debug] [Shared] Skipping extension [redacted].vscode-insiders/extensions/ms-vscode.js-debug-1.72.1 with lower version 1.72.1 in favour of /opt/visual-studio-code-insiders/resources/app/extensions/ms-vscode.js-debug with version 1.97.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants