Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectChatModels filtering by id doesn't work #236973

Closed
mohankumarelec opened this issue Dec 26, 2024 · 1 comment · Fixed by #236974
Closed

selectChatModels filtering by id doesn't work #236973

mohankumarelec opened this issue Dec 26, 2024 · 1 comment · Fixed by #236974
Assignees
@jrieken
Labels
api bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
January 2025

Comments

@mohankumarelec
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.96.2
  • OS Version: Mac OS

Steps to Reproduce:

  1. Create an Extension and try calling vscode.lm.selectChatModels({ id: modelId }) with a model id.
  2. All the models will be returned and filtering doesn't work.
@mohankumarelec mohankumarelec mentioned this issue Dec 26, 2024
Merged
@sandy081 sandy081 assigned jrieken and unassigned benibenj Dec 26, 2024
@jrieken jrieken added this to the January 2025 milestone Jan 6, 2025
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jan 7, 2025
@jrieken
Copy link
Member

jrieken commented Jan 7, 2025

Good find!

jrieken added a commit that referenced this issue Jan 7, 2025
@jrieken
Merge pull request #236974 from mohankumarelec/bug-236973
d80ac5c 
Fixes #236973
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 7, 2025
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
api bug Issue identified by VS Code Team member as probable bug chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Fixes #236973 mohankumarelec/vscode-fork
4 participants
@jrieken @TylerLeonhardt @mohankumarelec @benibenj