Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor GPU: Scroll x doesn't get applied when moving the cursor #233790

Open
Tyriar opened this issue Nov 13, 2024 · 2 comments · Fixed by #238679
Open

Editor GPU: Scroll x doesn't get applied when moving the cursor #233790

Tyriar opened this issue Nov 13, 2024 · 2 comments · Fixed by #238679
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues
Milestone
February 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 13, 2024

Repro:

  1. Enable GPU rendering
  2. Open a file with a long line
  3. Select a line rendered by GPU
  4. Scroll to the right
  5. Press home, 🐛 the cursor moves but the editor doesn't scroll to the left to reveal it

Image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues labels Nov 13, 2024
@Tyriar Tyriar added this to the November 2024 milestone Nov 13, 2024
@Tyriar Tyriar self-assigned this Nov 13, 2024
Tyriar added a commit that referenced this issue Nov 13, 2024
@Tyriar
Only update gpu scroll offset on scroll event
67c00bd 
Part of #233790
@Tyriar Tyriar mentioned this issue Nov 13, 2024
Merged
Tyriar added a commit that referenced this issue Nov 14, 2024
@Tyriar
Have ViewLinesGPu Listen to all view events of ViewLines
43b8cbd 
Part of #233790
Part of #233835
NikolaRHristov pushed a commit to CodeEditorLand/Editor that referenced this issue Nov 19, 2024
@Tyriar @NikolaRHristov
Only update gpu scroll offset on scroll event
aa1d778 
Part of microsoft#233790
NikolaRHristov pushed a commit to CodeEditorLand/Editor that referenced this issue Nov 19, 2024
@Tyriar @NikolaRHristov
Have ViewLinesGPu Listen to all view events of ViewLines
3b70750 
Part of microsoft#233790
Part of microsoft#233835
@Tyriar Tyriar modified the milestones: November 2024, January 2025 Dec 2, 2024
@Tyriar Tyriar moved this to In Progress in VS Code Editor GPU Renderer Jan 23, 2025
Tyriar added a commit that referenced this issue Jan 24, 2025
@Tyriar
Editor GPU: Pass content width through to scroll bar
90a24fb 
Fixes #233790
@Tyriar Tyriar mentioned this issue Jan 24, 2025
Merged
@Tyriar Tyriar moved this from In Progress to In Review in VS Code Editor GPU Renderer Jan 24, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in VS Code Editor GPU Renderer Jan 24, 2025
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 24, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Jan 27, 2025

There seem to be problems still with this:

  • It may be using device pixels when it should be using css pixels
  • Testing just now, there's no scroll bar for this very long line
    Image

@Tyriar Tyriar reopened this Jan 27, 2025
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Jan 27, 2025
@Tyriar Tyriar mentioned this issue Jan 27, 2025
Open
@Tyriar Tyriar modified the milestones: January 2025, February 2025 Jan 30, 2025
@Tyriar Tyriar closed this as completed by moving to Done in VS Code Editor GPU Renderer Jan 30, 2025
@Tyriar Tyriar reopened this Jan 31, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Jan 31, 2025

Also the change was reverted in #239326

@Tyriar Tyriar moved this from Done to Todo in VS Code Editor GPU Renderer Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues
Projects
VS Code Editor GPU Renderer
Status: Todo
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

Editor GPU: Pass content width through to scroll bar microsoft/vscode
1 participant
@Tyriar