Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Word Wrap gets lost after touching settings.json #21487

Closed
alexdima opened this issue Feb 27, 2017 · 2 comments
Closed

Toggle Word Wrap gets lost after touching settings.json #21487

alexdima opened this issue Feb 27, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Feb 27, 2017

  • Run Toggle Word Wrap

  • Execute View > Zoom In (this writes to user settings.json behind the scenes)

  • observe: the word wrap state is reset again, Toggle Word Wrap needs to be run again.

@bpasero
Copy link
Member

bpasero commented Feb 27, 2017

@alexandrudima I already looked into only updating the editor when the options change and have a fix ready. Still, I am currently not smart enough to handle the case where someone changes some word wrap unrelated editor setting (aka I only check for the entire editor setting being same or not). I can look into doing a simple object-diff on the editor setting and only update you with the options that actually have changed in the editor?

@bpasero
Copy link
Member

bpasero commented Feb 28, 2017

I pushed a change to only apply the minimal diff of editor settings that have changed, let's see how that goes.

@bpasero bpasero closed this as completed Feb 28, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants