Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap: scrolling up in large file makes the slider jump a little bit #21346

Closed
bpasero opened this issue Feb 24, 2017 · 4 comments
Closed

Minimap: scrolling up in large file makes the slider jump a little bit #21346

bpasero opened this issue Feb 24, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 24, 2017

Steps to Reproduce:

  1. macOS with zoom mode 1
  2. large file with 30k lines scrolled all the way down
  3. use mouse wheel to scroll up

=> at some point the thumb jumps up and then on the next scroll jumps down again
=> the other scrollbar does not show this behaviour

untitled

@bpasero bpasero added the editor-minimap Code/Text minimap widget issues label Feb 24, 2017
@alexdima
Copy link
Member

I've tried to work around this tremor in some cases, but there are still cases where it occurs.

The root cause is:

  • the minimap does not render partial lines. i.e. if a line is painted with 2px height, at y = 0 in the minimap there will always be a full line starting
  • the viewport renders partial lines
  • depending on the scrollTop, the viewport can contain N or N + 1 lines (where the first and last lines are only partially visible)
  • in such cases the minimap slider has this tremor.

Very annoying indeed.

@alexdima alexdima added this to the Backlog milestone Feb 24, 2017
@alexdima alexdima changed the title Minimap: scrolling up in large folder makes the thumb jump a little bit Minimap: scrolling up in large file makes the thumb jump a little bit Feb 24, 2017
@alexdima alexdima changed the title Minimap: scrolling up in large file makes the thumb jump a little bit Minimap: scrolling up in large file makes the slider jump a little bit Feb 24, 2017
@levani
Copy link

levani commented Mar 12, 2017

Not sure if it's the same problem but the slider also jumps when dragging by cursor.

scroll

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2017
@alexdima alexdima modified the milestones: On Deck, Backlog Jun 7, 2017
@jens1o
Copy link
Contributor

jens1o commented Jun 7, 2017

does f5e4e4f closes this issue? @alexandrudima

@alexdima
Copy link
Member

alexdima commented Jun 7, 2017

6df8165 should hopefully fix it

@bpasero bpasero added the verified Verification succeeded label Jun 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants