Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove canvas renderer #209276

Closed
Tyriar opened this issue Apr 1, 2024 · 1 comment · Fixed by #211449
Closed

Remove canvas renderer #209276

Tyriar opened this issue Apr 1, 2024 · 1 comment · Fixed by #211449
Assignees
@Tyriar
Labels
debt Code quality issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 1, 2024

Follow up for #209275; if all is well, remove canvas renderer from VS Code.
@Tyriar Tyriar added feature-request Request for new features or functionality debt Code quality issues terminal-rendering labels Apr 1, 2024
@Tyriar Tyriar added this to the On Deck milestone Apr 1, 2024
@Tyriar Tyriar self-assigned this Apr 1, 2024
Tyriar added a commit that referenced this issue Apr 1, 2024
@Tyriar
Remove xterm canvas renderer from fallback logic
596ee31 
This simplifies things a lot, the plan is to remove the canvas renderer
completely from VS Code if all goes well (#209276).

Fixes #209275
@Tyriar Tyriar mentioned this issue Apr 1, 2024
Merged
@Tyriar Tyriar modified the milestones: On Deck, May 2024 Apr 8, 2024
Tyriar added a commit that referenced this issue Apr 26, 2024
@Tyriar
Remove canvas renderer
6cdd364 
Fixes #209276
@Tyriar Tyriar mentioned this issue Apr 26, 2024
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 26, 2024
@benibenj benibenj added the verification-needed Verification of issue is requested label May 28, 2024
@Tyriar
Copy link
Member Author

Tyriar commented May 28, 2024

To verify ensure canvas is not an option for the gpuAcceleration setting

@alexr00 alexr00 added the verified Verification succeeded label May 28, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Remove canvas renderer microsoft/vscode
4 participants
@Tyriar @alexr00 @benibenj @vscodenpa