Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the --unity-launch flag #202545

Closed
ThatOneCalculator opened this issue Jan 15, 2024 · 3 comments · Fixed by #209471
Closed

Deprecate the --unity-launch flag #202545

ThatOneCalculator opened this issue Jan 15, 2024 · 3 comments · Fixed by #209471
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux verified Verification succeeded workbench-cli VS Code Command line issues
Milestone

Comments

@ThatOneCalculator
Copy link

ThatOneCalculator commented Jan 15, 2024

Reup of #40986

--unity-launch appears in the Linux desktop file and is currently undocumented. The flags acts as an alias to --new-window, forcing a new window to be spawned when opening files.

refs:

if (args['new-window'] || args['unity-launch'] || baseConfig.forceProfile || baseConfig.forceTempProfile) {
openNewWindow = true;
}

forceNewWindow: args['new-window'] || (!hasCliArgs && args['unity-launch']),

https://www.reddit.com/r/linuxquestions/comments/s4hvdv/comment/hsruzir/

@roblourens roblourens assigned bpasero and unassigned roblourens Jan 23, 2024
@bpasero bpasero assigned joaomoreno and Tyriar and unassigned bpasero Jan 24, 2024
@bpasero bpasero added the workbench-cli VS Code Command line issues label Jan 24, 2024
@Tyriar
Copy link
Member

Tyriar commented Jan 30, 2024

It was added to make things work a little nicer under unity, I think specifically shift+click opening a new window (but it was a long time ago I added it). It's slightly different to --new-window and I suspect we don't probably don't need it anymore so I don't think we should document it. When we remove it'll need some verification to make sure there aren't any bad regressions.

@Tyriar Tyriar assigned rzhao271 and unassigned joaomoreno and Tyriar Jan 30, 2024
@Tyriar Tyriar added debt Code quality issues linux Issues with VS Code on Linux labels Jan 30, 2024
@ThatOneCalculator
Copy link
Author

ThatOneCalculator commented Jan 30, 2024

Awesome, thanks for the clarification! Guessing the .desktop file will use --new-window then from now on since that's the desired behavior for most desktop environments nowadays

@ThatOneCalculator ThatOneCalculator changed the title Document the --unity-launch flag Deprecate the --unity-launch flag Jan 30, 2024
@Firestar-Reimu
Copy link

Firestar-Reimu commented Mar 26, 2024

https://aur.archlinux.org/cgit/aur.git/tree/code.desktop?h=visual-studio-code-bin

the --unity-launch leads to tiny cursors on HiDPI settings.

See #136390 (comment)

The fastest fix is to delete the --unity-launch option, just /usr/bin/code is fine.

@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Mar 26, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2024
@rzhao271 rzhao271 added this to the April 2024 milestone Apr 11, 2024
@connor4312 connor4312 added the verified Verification succeeded label Apr 24, 2024
m3t4f1v3 added a commit to m3t4f1v3/visual-studio-code-insiders-arch that referenced this issue May 10, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux verified Verification succeeded workbench-cli VS Code Command line issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants