Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird wording: Toggle skipping this file #19168

Closed
jrieken opened this issue Jan 24, 2017 · 5 comments
Closed

Weird wording: Toggle skipping this file #19168

jrieken opened this issue Jan 24, 2017 · 5 comments
Assignees

Comments

@jrieken
Copy link
Member

jrieken commented Jan 24, 2017

re #19096

The context menu contains an entry 'Toggle skipping this file' which is very weird wording. Toggle shouldn't be in the label but the label should toggle: 'Skip this file' and 'Antonyms(skip) this file' (whatever the reverse of skip should be, include?)

@roblourens
Copy link
Member

Would like to do that but I can't change the label, or dynamically add/remove options in that context menu. cc @isidorn

@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2017

I do not think so but @jrieken would know best as he designed the extension menu contribution point

@roblourens
Copy link
Member

I'm also curious if anyone has any thoughts on wording, whether we have one label or two. /cc @weinand

This is also related to #19180

To have two labels, we would probably need a 'when' clause for a stack frame's presentation hint or something like that.

@jrieken
Copy link
Member Author

jrieken commented Jan 25, 2017

re #19168 (comment): you need to have two commands which show depending on some context

@roblourens
Copy link
Member

I'll leave it at least for now since we have UI for the skip status - presentationHint and tooltip. Keeping #19180.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants