Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serve-web: error could not parse host: invalid socket address syntax #191067

Closed
Ali-Flt opened this issue Aug 23, 2023 · 0 comments · Fixed by #191146
Closed

serve-web: error could not parse host: invalid socket address syntax #191067

Ali-Flt opened this issue Aug 23, 2023 · 0 comments · Fixed by #191146
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2023

Comments

@Ali-Flt
Copy link

Ali-Flt commented Aug 23, 2023 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: code-insiders_1.82.0-1692769953_amd64.deb
  • OS Version: Ubuntu 20:04 (inside docker container)

Steps to Reproduce:

  1. Run code-insiders serve-web --host 0.0.0.0

It seems like the --host argument does not accept anything.
Related to #191014
@connor4312 connor4312 assigned connor4312 and unassigned bhavyaus Aug 23, 2023
@connor4312 connor4312 mentioned this issue Aug 23, 2023
Merged
connor4312 added a commit that referenced this issue Aug 23, 2023
@connor4312
cli: serve-web listener improvements
faa55a5 
- Allow listening on a socket path (required manually implementing
  the Accept trait), fixes #191043
- Parse the host syntax correctly, fixes #191067
connor4312 added a commit that referenced this issue Aug 23, 2023
@connor4312
cli: serve-web listener improvements (#191146)
f7a7d94 
- Allow listening on a socket path (required manually implementing
  the Accept trait), fixes #191043
- Parse the host syntax correctly, fixes #191067
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 23, 2023
@vscodenpa vscodenpa added this to the August 2023 milestone Aug 23, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2023
@Ali-Flt Ali-Flt mentioned this issue Aug 30, 2023
Closed
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2023
@roblourens roblourens added the verified Verification succeeded label Aug 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

cli: serve-web listener improvements microsoft/vscode
5 participants
@roblourens @connor4312 @bhavyaus @Ali-Flt @vscodenpa