Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert use of new certificate loading #189133

Closed
chrmarti opened this issue Jul 28, 2023 · 2 comments
Closed

Revert use of new certificate loading #189133

chrmarti opened this issue Jul 28, 2023 · 2 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release proxy Issues regarding network proxies verified Verification succeeded
Milestone
July 2023

Comments

@chrmarti
Copy link
Collaborator

Still investigating two issues:

It will be safest to revert to the old certificate loading for now until we get more time for investigating and testing fixes for these issues.
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release proxy Issues regarding network proxies labels Jul 28, 2023
@chrmarti chrmarti added this to the July 2023 milestone Jul 28, 2023
@chrmarti chrmarti self-assigned this Jul 28, 2023
@chrmarti chrmarti mentioned this issue Jul 28, 2023
Merged
chrmarti added a commit that referenced this issue Jul 28, 2023
@chrmarti
Revert use of new certificate loading (#189133)
5107d97
chrmarti added a commit that referenced this issue Jul 28, 2023
@chrmarti
Revert use of new certificate loading (#189133)
0e059b9
chrmarti added a commit that referenced this issue Jul 28, 2023
@chrmarti
Revert use of new certificate loading (#189133)
7fd9b4d
chrmarti added a commit that referenced this issue Jul 28, 2023
@chrmarti
Revert use of new certificate loading (#189133)
58882c2
@alexr00
Copy link
Member

alexr00 commented Jul 28, 2023

Closing for verification.

@alexr00 alexr00 closed this as completed Jul 28, 2023
@chrmarti chrmarti mentioned this issue Jul 28, 2023
Merged
chrmarti added a commit that referenced this issue Jul 28, 2023
@chrmarti
Revert use of new certificate loading (#189133)
d0db1e1
@chrmarti chrmarti mentioned this issue Jul 28, 2023
Closed
chrmarti added a commit that referenced this issue Jul 28, 2023
@chrmarti
Revert use of new certificate loading (#189133)
839f033
@chrmarti
Copy link
Collaborator Author

chrmarti commented Jul 28, 2023 •
edited
Loading

To verify:

  • Set log level to trace.
  • Reload window.
  • Check that the Extension Host output channel does not contain any ProxyResolver#tls.connect entries.
  • (To cross-check you can re-enable the reverted behavior with the user setting: "http.experimental.systemCertificatesV2": true)

@ulugbekna ulugbekna added the verified Verification succeeded label Jul 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release proxy Issues regarding network proxies verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

No branches or pull requests
3 participants
@chrmarti @ulugbekna @alexr00