Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more terminal links by default #188108

Closed
Tracked by #189320
Tyriar opened this issue Jul 17, 2023 · 1 comment · Fixed by #189230
Closed
Tracked by #189320

Show more terminal links by default #188108

Tyriar opened this issue Jul 17, 2023 · 1 comment · Fixed by #189230
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2023

Context: #188101 (comment)

Let's explore pulling all the links when you open it, with some reasonable timeout. We could also do this lazily by showing just the buffer initially but when you filter we backfill the results.
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-links labels Jul 17, 2023
@Tyriar Tyriar added this to the August 2023 milestone Jul 17, 2023
@Tyriar Tyriar self-assigned this Jul 17, 2023
Tyriar added a commit that referenced this issue Jul 29, 2023
@Tyriar
Show viewport links immediately, all links on filter
d8ae0ea 
This also de-duplicates word links when they are shown in other
categories and shows categories on filter.

Fixes #188108
@Tyriar Tyriar mentioned this issue Jul 29, 2023
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2023
@beto811 beto811 mentioned this issue Jul 31, 2023
Closed
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 3, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Aug 28, 2023

To verify review the expected behavior in #189230 and make sure it works.

@Tyriar Tyriar added the verification-needed Verification of issue is requested label Aug 28, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Aug 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

Show viewport links immediately, all links on filter microsoft/vscode
3 participants
@Tyriar @joyceerhl @vscodenpa