EnvironmentVariableCollection.description only works for one extension

[Tyriar]

This is the reason js-debug isn't working but git is:

vscode/src/vs/platform/terminal/common/environmentVariableCollection.ts

Lines 139 to 161 in 01d4949

	getVariableMap(scope: EnvironmentVariableScope | undefined): Map<string, IExtensionOwnedEnvironmentVariableMutator[]> {
	const result = new Map<string, IExtensionOwnedEnvironmentVariableMutator[]>();
	this.map.forEach((mutators, _key) => {
	const filteredMutators = mutators.filter(m => filterScope(m, scope));
	if (filteredMutators.length > 0) {
	// All of these mutators are for the same variable because they are in the same scope, hence choose anyone to form a key.
	result.set(filteredMutators[0].variable, filteredMutators);
	}
	});
	return result;
	}
	getDescriptionMap(scope: EnvironmentVariableScope | undefined): Map<string, string | undefined> {
	const result = new Map<string, string | undefined>();
	this.descriptionMap.forEach((mutators, _key) => {
	const filteredMutators = mutators.filter(m => filterScope(m, scope, true));
	if (filteredMutators.length > 0) {
	// There should be exactly one description per extension per scope.
	result.set(filteredMutators[0].extensionIdentifier, filteredMutators[0].description);
	}
	});
	return result;
	}

This is probably a good candidate for recovery, not a good reason to push 1.80.0 out though.

[Tyriar]

Fixed in main #186861

[karrtikr]

Thanks for taking care of it while I was out! Can this be closed?

[Tyriar]

@karrtikr this one's going into the recovery build, didn't quite make the cut for 1.80.0.

[meganrogge]

@karrtikr verified that JavaScript debug terminals are getting the expected env - can you pls lmk what the repro steps were here?

[karrtikr]

You can add the following setting to activate description for Python ext: "python.experiments.optInto": ["pythonTerminalEnvVarActivation"] in User settings and reload.

After which, if you select a virtual environment (Python: Select Interpreter), it should use env collection to activate terminal with appropriate description, something like:

Description is the "Enable Nodejs..." string next to "Javascript debugger:", it appears when hovering over the terminal label.

[meganrogge]

[karrtikr]

Seems to work 👍

[Tyriar]

The actual verify steps for this is to ensure 2 list items appear in the same section. Verified below.

Insiders:

Stable: