-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make accessibility help generic #183363
Labels
accessibility
Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues
feature-request
Request for new features or functionality
on-release-notes
Issue/pull request mentioned in release notes
on-testplan
Milestone
Comments
Tyriar
added
feature-request
Request for new features or functionality
accessibility
Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues
labels
May 24, 2023
Will address #184176 |
VSCodeTriageBot
added
the
unreleased
Patch has not yet been released in VS Code Insiders
label
Jun 8, 2023
@meganrogge should this be reopened to track all the follow ups in #184435? |
VSCodeTriageBot
added
insiders-released
Patch has been released in VS Code Insiders
and removed
unreleased
Patch has not yet been released in VS Code Insiders
labels
Jun 9, 2023
VSCodeTriageBot
removed
the
insiders-released
Patch has been released in VS Code Insiders
label
Jun 13, 2023
Remaining help menu adoption:
To do later:
|
3 tasks
3 tasks
meganrogge
added
the
on-release-notes
Issue/pull request mentioned in release notes
label
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues
feature-request
Request for new features or functionality
on-release-notes
Issue/pull request mentioned in release notes
on-testplan
Currently we have a few different accessibility help dialogs that appear, for example:
Editor:
Terminal:
Chat view:
They each work similar but have different implementations and different commands (they probably share some code, I'm not sure).
My proposal is to have a single command "Show Accessibility Help" bound to alt+f1 across the whole workbench, components can register their own custom text which ends up showing in a centered monaco editor. From there we can trap the focus on the editor and escape or clicking out of the dialog would hide it and return focus to the previous
activeElement
.The presentation of it could look similar to the editor dialog but have a monaco editor inside instead. It could also have a 50% black background to give a strong indication that you can click here to get out. The actual visual presentation isn't too important but with a single implementation we can make it look good just one time.
This would lead to a consistent experience across all components that use it, shared implementation, a single lazy loaded monaco editor that's only constructed when needed and it wouldn't lead to potential issues such as getting the content and the help message mixed up when it's currently sharing an editor.
cc @jooyoungseo
The text was updated successfully, but these errors were encountered: