Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accessibility help generic #183363

Closed
Tyriar opened this issue May 24, 2023 · 4 comments · Fixed by #184435
Closed

Make accessibility help generic #183363

Tyriar opened this issue May 24, 2023 · 4 comments · Fixed by #184435
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 24, 2023

Currently we have a few different accessibility help dialogs that appear, for example:

Editor:

The editor help is a popup with a header and div

Terminal:

The terminal has a monaco editor appear inline inside the terminal

Chat view:

The chat view reuses the prompt monaco editor

They each work similar but have different implementations and different commands (they probably share some code, I'm not sure).

My proposal is to have a single command "Show Accessibility Help" bound to alt+f1 across the whole workbench, components can register their own custom text which ends up showing in a centered monaco editor. From there we can trap the focus on the editor and escape or clicking out of the dialog would hide it and return focus to the previous activeElement.

The presentation of it could look similar to the editor dialog but have a monaco editor inside instead. It could also have a 50% black background to give a strong indication that you can click here to get out. The actual visual presentation isn't too important but with a single implementation we can make it look good just one time.

This would lead to a consistent experience across all components that use it, shared implementation, a single lazy loaded monaco editor that's only constructed when needed and it wouldn't lead to potential issues such as getting the content and the help message mixed up when it's currently sharing an editor.

cc @jooyoungseo

@Tyriar Tyriar added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels May 24, 2023
@meganrogge
Copy link
Contributor

Will address #184176

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 8, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the June 2023 milestone Jun 8, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Jun 8, 2023

@meganrogge should this be reopened to track all the follow ups in #184435?

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 9, 2023
@meganrogge meganrogge reopened this Jun 13, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 13, 2023
@meganrogge
Copy link
Contributor

All issues addressed besides the ones that will be handled by @amunger and @hediet

@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants