Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide helper for terminal actions to get or create a terminal that accepts input #181249

Closed
Tyriar opened this issue May 1, 2023 · 0 comments · Fixed by #181272
Closed

Provide helper for terminal actions to get or create a terminal that accepts input #181249

Tyriar opened this issue May 1, 2023 · 0 comments · Fixed by #181272
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal General terminal issues that don't fall under another label
Milestone
May 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented May 1, 2023

This fix could be done in a nicer way by adding optional options to getActiveOrCreateInstance, something like { acceptsInput?: boolean }

#180467
@Tyriar Tyriar added tasks Task system issues debt Code quality issues terminal General terminal issues that don't fall under another label labels May 1, 2023
@Tyriar Tyriar added this to the May 2023 milestone May 1, 2023
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge May 1, 2023
Tyriar added a commit that referenced this issue May 1, 2023
@Tyriar
Add acceptsInput option an move reveal active to term service
fc9376d 
Fixes #181249
@Tyriar Tyriar mentioned this issue May 1, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Add acceptsInput option an move reveal active to term service microsoft/vscode
3 participants
@Tyriar @meganrogge @vscodenpa