undefined in ariaLabel

[meganrogge]

Would it be possible to clarify the meaning of the message 'undefined use Shift + F7 to navigate changes'? More specifically why the word undefined in the message?

Originally posted by @jvesouza in #172465 (comment)

[meganrogge]

We need let ariaLabel = options.ariaLabel || ''; here

vscode/src/vs/editor/browser/widget/diffEditorWidget.ts

Line 1292 in b44d1fb

let ariaLabel = options.ariaLabel;

[joyceerhl]

I cannot seem to get any hint about the diff editor to be read by Narrator 🤔

[meganrogge]

@joyceerhl with screen reader mode on and diff editor verbosity enabled, open a diff editor from the scm view. It will only read the hint when you open it initially

[meganrogge]

Note that I haven't tried with narrator - only nvda

[meganrogge]

Possible you disabled the setting when testing earlier? Closing to see if someone else can trigger it

[Tyriar]

undefined is gone:

There is a rogue space before "use", not that important but you may want to fix that? It's not clear what undefined is meant to be here when truthy?