-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Authentication growing list of creds, odd behavior #179202
Comments
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.77.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! |
You sure this didn't happen in 1.76 and is hangover from then? Can you clean those up and try from scratch with 1.77 and tell me if you still see the issue We added a fix for this in 1.77 so I would expect that it would stop doing this from now on. |
I had actually made a fresh VM and ensured vscode was on 1.77.0 and those screenshots I took are from that environment setup |
I was looking into this with Monil and while my setup isn't as "pristine" as his, I started the day on 1.77.0 by wiping my credential manager and have grown back up to 41(!) entries (shared between 6 extensions) over the course of repeatedly closing and re-opening VS Code throughout the day. |
Do you have multiple windows of VS Code open? |
Not in my VM test, just a single instance that I will close and open. The error doesnt happen each time but after 2-3 something typically happens |
Can you follow these steps so that we can get more information on what's going on?
|
Ok classic bug repro didnt get exactly the same behavior as the first time, but I did get it to grow by a 2-chunk entry.
Microsoft Authentication
Log (Main) Output
Cred Manager
|
Update - tried again this morning. Same basic steps of just exiting and opening vscode
Microsoft Authentication
Main Log
credman entries
|
Here's a hunch that I have on why this is happening (at least for the case where we see "Session removed in another window" even though we only have one window open):
|
I looked into this today... it's a tricky tricky one... My hunch is that the issue is in
happening here:
and
happening here:
but these errors are totally unexpected... because Because these errors are thrown, we end up returning something different than the added up content:
and that is probably why you have issues. Open questions:
I'm thinking about getting rid of the concept of |
Yeah it's likely related. If it fails to get all the chunks then it's going to fail to decrypt. |
I just sent a PR (should be in tomorrow) that will maybe help... at the very least it will give me more logs to play with. Can you get the Insiders version of VS Code and let me know how it goes? |
I still see this happening on 1.78.0-insider@079272e4a37ceecd22dcebc3566bb46c8580a13c, but anecdotally, less frequently than on stable where I can reliably get it to lose my credentials within 3 reloads. Main2023-04-11 15:38:10.402 [trace] Setting password using keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/edf4fffd-76b3-4bc9-95b4-af5e86822a36 2023-04-11 15:38:10.404 [trace] Setting password using keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/6f8b58d2-bc29-4b81-8342-3d52b518e794 2023-04-11 15:38:10.405 [trace] Setting password using keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/1efa2532-01d7-499a-828e-1f326f1043c3 2023-04-11 15:38:10.406 [trace] Setting password using keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/771ae278-8846-4540-8721-332080e2a76f 2023-04-11 15:38:10.427 [trace] Deleted 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/771ae278-8846-4540-8721-332080e2a76f 2023-04-11 15:38:10.483 [trace] Deleted 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/6f8b58d2-bc29-4b81-8342-3d52b518e794 2023-04-11 15:38:10.486 [trace] Deleted 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/1efa2532-01d7-499a-828e-1f326f1043c3 2023-04-11 15:38:10.531 [trace] Set 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/771ae278-8846-4540-8721-332080e2a76f 2023-04-11 15:38:10.534 [trace] Getting password from keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/771ae278-8846-4540-8721-332080e2a76f 2023-04-11 15:38:10.534 [trace] Deleted 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/edf4fffd-76b3-4bc9-95b4-af5e86822a36 2023-04-11 15:38:10.578 [trace] Set 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/6f8b58d2-bc29-4b81-8342-3d52b518e794 2023-04-11 15:38:10.627 [trace] Set 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/1efa2532-01d7-499a-828e-1f326f1043c3 2023-04-11 15:38:10.630 [trace] Got 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/771ae278-8846-4540-8721-332080e2a76f 2023-04-11 15:38:10.636 [trace] Getting password from keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/6f8b58d2-bc29-4b81-8342-3d52b518e794 2023-04-11 15:38:10.637 [trace] Getting password from keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/1efa2532-01d7-499a-828e-1f326f1043c3 2023-04-11 15:38:10.637 [trace] Did not get a password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/1efa2532-01d7-499a-828e-1f326f1043c3 2023-04-11 15:38:10.638 [trace] Got 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/6f8b58d2-bc29-4b81-8342-3d52b518e794 2023-04-11 15:38:10.689 [trace] Set 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/edf4fffd-76b3-4bc9-95b4-af5e86822a36 2023-04-11 15:38:10.697 [trace] Getting password from keytar: vscode-insidersvscode.microsoft-authentication 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/edf4fffd-76b3-4bc9-95b4-af5e86822a36 2023-04-11 15:38:10.755 [trace] Got 2-chunked password from keytar for account: 72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/edf4fffd-76b3-4bc9-95b4-af5e86822a36 Authentication2023-04-11 15:37:46.644 [info] Reading sessions from secret storage... 2023-04-11 15:37:46.644 [error] Key was not found in SecretStorage. 2023-04-11 15:37:46.644 [info] Got 4 stored sessions 2023-04-11 15:37:46.644 [trace] Read the following stored session with scopes: email offline_access openid profile 2023-04-11 15:37:46.644 [info] Refreshing token for scopes: email offline_access openid profile 2023-04-11 15:37:46.644 [trace] Read the following stored session with scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:46.646 [info] Refreshing token for scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:46.646 [trace] Read the following stored session with scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:46.646 [info] Refreshing token for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:46.646 [trace] Read the following stored session with scopes: VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile 2023-04-11 15:37:46.646 [info] Refreshing token for scopes: VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile 2023-04-11 15:37:47.677 [info] Setting token for scopes: email offline_access openid profile 2023-04-11 15:37:47.677 [info] Token refresh success for scopes: email offline_access openid profile 2023-04-11 15:37:47.940 [info] Setting token for scopes: VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile 2023-04-11 15:37:47.941 [info] Token refresh success for scopes: VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile 2023-04-11 15:37:48.049 [info] Setting token for scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:48.049 [info] Token refresh success for scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:48.096 [info] Setting token for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:48.096 [info] Token refresh success for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:48.134 [info] Getting sessions for all scopes... 2023-04-11 15:37:48.134 [info] Got 4 sessions for all scopes... 2023-04-11 15:37:48.141 [info] Getting sessions for the following scopes: email offline_access openid profile 2023-04-11 15:37:48.141 [info] Got 1 sessions for scopes: email offline_access openid profile 2023-04-11 15:37:48.141 [info] Token available from cache (for scopes email offline_access openid profile), expires in 4532536 milliseconds 2023-04-11 15:37:48.141 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:48.141 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:48.142 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 5154907 milliseconds 2023-04-11 15:37:49.494 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:49.494 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:49.494 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4632602 milliseconds 2023-04-11 15:37:50.047 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:50.047 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:37:50.047 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4632049 milliseconds 2023-04-11 15:38:10.388 [info] Stored token for scopes: email offline_access openid profile 2023-04-11 15:38:10.388 [info] Stored token for scopes: VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile 2023-04-11 15:38:10.388 [info] Stored token for scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.388 [info] Stored token for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.639 [info] Session removed in another window with scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.639 [info] Logging out of session '72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/1efa2532-01d7-499a-828e-1f326f1043c3' 2023-04-11 15:38:10.639 [info] Sending change event for session that was removed with scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.639 [info] Logged out of session '72f988bf-86f1-41af-91ab-2d7cd011db47/58eeb6bc-7177-4e34-ba5b-089f64f616c6/1efa2532-01d7-499a-828e-1f326f1043c3' with scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.645 [info] Getting sessions for the following scopes: email offline_access openid profile 2023-04-11 15:38:10.645 [info] Got 1 sessions for scopes: email offline_access openid profile 2023-04-11 15:38:10.645 [info] Token available from cache (for scopes email offline_access openid profile), expires in 4510032 milliseconds 2023-04-11 15:38:10.645 [info] Getting sessions for the following scopes: email offline_access openid profile 2023-04-11 15:38:10.645 [info] Got 1 sessions for scopes: email offline_access openid profile 2023-04-11 15:38:10.645 [info] Token available from cache (for scopes email offline_access openid profile), expires in 4510032 milliseconds 2023-04-11 15:38:10.646 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.646 [trace] No session found with idtoken scopes... Using fallback scope list of: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 offline_access 2023-04-11 15:38:10.646 [info] Got 0 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/.default VSCODE_CLIENT_ID:496719b1-dc2e-4adb-9d15-48372642ccfb VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.646 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.647 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.647 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4611449 milliseconds 2023-04-11 15:38:10.663 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.663 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:10.663 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4611433 milliseconds 2023-04-11 15:38:16.329 [info] Getting sessions for the following scopes: VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile 2023-04-11 15:38:16.329 [info] Got 1 sessions for scopes: VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile 2023-04-11 15:38:16.329 [info] Token available from cache (for scopes VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 ea26ff51-7128-431d-a714-d6f3c6df55fc/WaveSpacesUser email offline_access openid profile), expires in 4408612 milliseconds 2023-04-11 15:38:16.330 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:16.330 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:16.330 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4605766 milliseconds 2023-04-11 15:38:16.443 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:16.443 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:16.443 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4605653 milliseconds 2023-04-11 15:38:16.505 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:16.505 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:38:16.505 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4605591 milliseconds 2023-04-11 15:39:50.325 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:39:50.325 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:39:50.325 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4511770 milliseconds 2023-04-11 15:39:50.444 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:39:50.444 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:39:50.444 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4511651 milliseconds 2023-04-11 15:39:50.554 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:39:50.554 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:39:50.554 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4511542 milliseconds 2023-04-11 15:40:10.874 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:40:10.874 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:40:10.875 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4491221 milliseconds 2023-04-11 15:40:10.996 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:40:10.996 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:40:10.996 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4491099 milliseconds 2023-04-11 15:40:11.105 [info] Getting sessions for the following scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:40:11.105 [info] Got 1 sessions for scopes: 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile 2023-04-11 15:40:11.105 [info] Token available from cache (for scopes 499b84ac-1321-427f-aa17-267ca6975798/user_impersonation VSCODE_CLIENT_ID:ea26ff51-7128-431d-a714-d6f3c6df55fc VSCODE_TENANT:72f988bf-86f1-41af-91ab-2d7cd011db47 email offline_access openid profile), expires in 4490990 milliseconds (11 was the steady-state before I started testing) ~ ➜ (cmdkey /list | Where-Object { $_ -like "*Target:*" -and $_ -like "*vscode-insidersvscode.microsoft-*" }).Count
11
~ ➜ code-insiders
~ ➜ code-insiders
~ ➜ (cmdkey /list | Where-Object { $_ -like "*Target:*" -and $_ -like "*vscode-insidersvscode.microsoft-*" }).Count
15
~ ➜ code-insiders
~ ➜ code-insiders
~ ➜ (cmdkey /list | Where-Object { $_ -like "*Target:*" -and $_ -like "*vscode-insidersvscode.microsoft-*" }).Count
16
~ ➜ code-insiders
~ ➜ (cmdkey /list | Where-Object { $_ -like "*Target:*" -and $_ -like "*vscode-insidersvscode.microsoft-*" }).Count
18
~ ➜ code-insiders
~ ➜ code-insiders
~ ➜ (cmdkey /list | Where-Object { $_ -like "*Target:*" -and $_ -like "*vscode-insidersvscode.microsoft-*" }).Count
24 |
This might be unrelated, but I'll still post it here: I had the
When signing into Github again, it first failed (I guess this was the OAuth sign in version), so I signed in using the second method (i.e. by entering the passphrase VSCode gave me). This seems to work now, even after restarts of VSCode. I hope this can help you, or anyone else experiencing it, resolve the issue. |
Hi @TylerLeonhardt! Has there been any update here since the last attempt to get more debug info? |
Hello! This issue is now fixed in Insiders with us moving away from Keytar and on to Electron safeStorage for storing secrets 🎉 More info: #185677 |
Verification:
|
Does this issue occur when all extensions are disabled?: Yes/No
Apologies this won't be the clearest report since we are having a hard time coming to a minimum repro and are confused ourselves. But we have been seeing very weird behavior with the Microsoft Authentication flow. Feel free to reach out to me on teams happy to talk it through.
Growing list of credentials.
On several of our machines we are seeing hundreds of entries in the windows credential manager seemingly over time for microsoft authentication. And eventually this results in the credmanager being too full, and requiring users to sign in repeatedly.
An example of this at a small scale. We have 2 extensions that both use microsoft auth
Signed into Extension A. This does hit two different apis so 4 chunked entries is reasonable

Signed into Extension B. This hits one api so an additional 2 entries is reasonable

Just reloading vscode a few different times led to a state where we lost a stored entry chunk for ...c44

This means on the next reload we had to re-sign in since there wasnt a valid token found.

This led to 2 new entries for the new token. But somehow(?) the c44 and c44-1 chunk came back? But we also just re-authenticatd. so our list has now grown for no reason. Our team owns several extensions and relies on microsoft authentication so we are worried about this growing when signed into multiple
We tried to figure out some sort of pattern to this, looks like there was some logic added to delete existing tokens and wondering if it could be some sort of race condition happening? We didnt specifically notice this behavior in 1.76 so also wondering if it could be related to the changes in 1.77
The text was updated successfully, but these errors were encountered: