Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve terminal find behavior when there are more than 1000 results #178017

Closed
Tyriar opened this issue Mar 22, 2023 · 3 comments · Fixed by #182917
Closed

Improve terminal find behavior when there are more than 1000 results #178017

Tyriar opened this issue Mar 22, 2023 · 3 comments · Fixed by #182917
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
May 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2023

Currently find in the terminal behaves a little strangely when there are more than 1000 results. The result count may not show up at all or it may say "0 of -1":

image
image

We should behave more like the editor does:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal-find Relating the terminal's find widget labels Mar 22, 2023
@Tyriar Tyriar added this to the Backlog milestone Mar 22, 2023
@Tyriar Tyriar mentioned this issue Mar 22, 2023
Closed
@Tyriar Tyriar added the upstream-issue-linked This is an upstream issue that has been reported upstream label Mar 22, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Mar 22, 2023

Upstream: xtermjs/xterm.js#4444

@Tyriar Tyriar mentioned this issue Mar 22, 2023
Closed
@jeanp413
Copy link
Contributor

jeanp413 commented May 7, 2023 •
edited
Loading

Created a PR upstream xtermjs/xterm.js#4504

Once merged and published I'll create a PR updating the findWidget here

@Tyriar Tyriar modified the milestones: Backlog, May 2023 May 8, 2023
jeanp413 added a commit to jeanp413/vscode that referenced this issue May 18, 2023
@jeanp413
Fixes microsoft#178017
393d160
@jeanp413 jeanp413 mentioned this issue May 18, 2023
Merged
@jeanp413
Copy link
Contributor

Continuation PR #182917

Tyriar added a commit that referenced this issue May 19, 2023
@Tyriar
xterm@5.2.0-beta.43
2b68847 
Part of #178017
@Tyriar Tyriar mentioned this issue May 19, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 19, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Fix Improve terminal find behavior when there are more than 1000 results jeanp413/vscode
5 participants
@Tyriar @rzhao271 @jeanp413 @meganrogge @vscodenpa