-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not convinced Undo Accept Part is needed #172153
Comments
This is to advertise the keybinding |
I am wondering why would a user want to use that one compared to "Ctrl+Z" which is already in their muscle memory? |
Because Ctrl+Right/Left forms a nice pair of keybindings. If you have a strong preference to remove it, I can remove that keybinding + the menu entry. |
No strong preference. I was just wondering out load. Let's just make sure we have telemetry and we see how much users use it :) |
I don't mind having it in the menu but the keybinding is unfortunately annoying. At least on mac it overlaps with word navigation and I often see myself undoing changes instead of navigating to the word or line start. I, personally, have the keybinding disabled for that reason |
Ok. One more reason to get rid of the whole action :) |
Testing #172029
We are teaching users to use Undo Accept Part, while in reality everyone will use Cmd+Z and it will just work.
Why do we think it is important to have this action? Is it bringing something in addition to the regular undo?
We can also see click rates from users and we can then remove it later if needed.
The text was updated successfully, but these errors were encountered: