Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not convinced Undo Accept Part is needed #172153

Closed
isidorn opened this issue Jan 24, 2023 · 6 comments · Fixed by #179988
Closed

Not convinced Undo Accept Part is needed #172153

isidorn opened this issue Jan 24, 2023 · 6 comments · Fixed by #179988
Assignees
Labels
feature-request Request for new features or functionality inline-completions insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2023

Testing #172029

We are teaching users to use Undo Accept Part, while in reality everyone will use Cmd+Z and it will just work.
Why do we think it is important to have this action? Is it bringing something in addition to the regular undo?

We can also see click rates from users and we can then remove it later if needed.

Screenshot 2023-01-24 at 14 04 25

@hediet
Copy link
Member

hediet commented Jan 25, 2023

This is to advertise the keybinding Ctrl+Left.

@hediet hediet added the under-discussion Issue is under discussion for relevance, priority, approach label Jan 25, 2023
@hediet hediet added this to the On Deck milestone Jan 25, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Jan 25, 2023

I am wondering why would a user want to use that one compared to "Ctrl+Z" which is already in their muscle memory?

@hediet
Copy link
Member

hediet commented Jan 25, 2023

Because Ctrl+Right/Left forms a nice pair of keybindings. If you have a strong preference to remove it, I can remove that keybinding + the menu entry.

@isidorn
Copy link
Contributor Author

isidorn commented Jan 25, 2023

No strong preference. I was just wondering out load. Let's just make sure we have telemetry and we see how much users use it :)
Also let's see what @jrieken says since he says he uses it in his daily flow.

@jrieken
Copy link
Member

jrieken commented Jan 26, 2023

I don't mind having it in the menu but the keybinding is unfortunately annoying. At least on mac it overlaps with word navigation and I often see myself undoing changes instead of navigating to the word or line start. I, personally, have the keybinding disabled for that reason

@isidorn
Copy link
Contributor Author

isidorn commented Jan 26, 2023

Ok. One more reason to get rid of the whole action :)
If there is no keybindings, there is no need for the menu. Users will just use cmd+Z.

@hediet hediet added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jan 27, 2023
@hediet hediet modified the milestones: On Deck, February 2023 Jan 27, 2023
@hediet hediet modified the milestones: February 2023, March 2023 Feb 20, 2023
@hediet hediet modified the milestones: March 2023, April 2023 Mar 20, 2023
hediet added a commit that referenced this issue Apr 14, 2023
hediet added a commit that referenced this issue Apr 17, 2023
hediet added a commit that referenced this issue Apr 17, 2023
hediet added a commit that referenced this issue Apr 17, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 17, 2023
@hediet hediet added verification-needed Verification of issue is requested verified Verification succeeded labels Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality inline-completions insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants