Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass translations down to Markdown Language Server #172060

Closed
TylerLeonhardt opened this issue Jan 23, 2023 · 0 comments · Fixed by #172884
Closed

Pass translations down to Markdown Language Server #172060

TylerLeonhardt opened this issue Jan 23, 2023 · 0 comments · Fixed by #172884
Assignees
@mjbvz
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
February 2023

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jan 23, 2023 •
edited
Loading

Follow up from #164438

All the pieces of the puzzle should be here:

All that's left to do is leverage the vscode.l10n.bundle or vscode.l10n.uri API along with l10n.config in @vscode/l10n on the server side to connect the dots. This will allow this extension to be fully localized for the desktop and the web.
@TylerLeonhardt TylerLeonhardt mentioned this issue Jan 23, 2023
Closed
2 tasks
@mjbvz mjbvz added this to the February 2023 milestone Jan 23, 2023
@mjbvz mjbvz added the debt Code quality issues label Jan 23, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Jan 31, 2023
@mjbvz
Pass translations down to Markdown Language Server
dcdc35b 
Fixes microsoft#172060
@mjbvz mjbvz mentioned this issue Jan 31, 2023
Merged
mjbvz added a commit that referenced this issue Jan 31, 2023
@mjbvz
Pass translations down to Markdown Language Server (#172884)
c18f80a 
Fixes #172060
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

Pass translations down to Markdown Language Server mjbvz/vscode
3 participants
@TylerLeonhardt @mjbvz @vscodenpa