Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close, minimize and maximize button are gone after today's update (1.74.0) #165337

Closed
edwardchenchen opened this issue Nov 3, 2022 · 2 comments · Fixed by #165384
Closed

close, minimize and maximize button are gone after today's update (1.74.0) #165337

edwardchenchen opened this issue Nov 3, 2022 · 2 comments · Fixed by #165384
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded windows VS Code on Windows issues
Milestone
November 2022

Comments

@edwardchenchen
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.74.0-insider (user setup)
Commit: 86f0f9b
Date: 2022-11-03T05:36:55.498Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19043
Sandboxed: Yes
image
@edwardchenchen edwardchenchen changed the title close, minimize and maximize button are gone after today's update close, minimize and maximize button are gone after today's update (1.74.0) Nov 3, 2022
@furai
Copy link

furai commented Nov 3, 2022

It affects as well other distributions:

Version: 1.74.0-insider
Commit: 86f0f9bfa268fe21af7efae37d8f0da1dba8137f
Date: 2022-11-03T05:37:22.038Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 6.0.6-arch1-1
Sandboxed: Yes

@gjsjohnmurray
Copy link
Contributor

"window.experimental.windowControlsOverlay.enabled": true fixes it for me.

@median-dxz median-dxz mentioned this issue Nov 3, 2022
Closed
@zctmdc zctmdc mentioned this issue Nov 3, 2022
Closed
@joaomoreno joaomoreno assigned sbatten and unassigned hediet Nov 3, 2022
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority windows VS Code on Windows issues and removed triage-needed labels Nov 3, 2022
@joaomoreno joaomoreno added this to the November 2022 milestone Nov 3, 2022
@sbatten sbatten mentioned this issue Nov 3, 2022
Merged
sbatten added a commit that referenced this issue Nov 3, 2022
@sbatten
proper check for WCO
e8f3536 
fixes #165337
This was referenced Nov 3, 2022
Closed
Closed
sbatten added a commit that referenced this issue Nov 3, 2022
@sbatten
proper check for WCO (#165384)
bc1088e 
fixes #165337
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 3, 2022
@sbatten sbatten mentioned this issue Nov 3, 2022
Closed
@gjsjohnmurray gjsjohnmurray mentioned this issue Nov 3, 2022
Closed
@rzhao271 rzhao271 mentioned this issue Nov 3, 2022
Open
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 3, 2022
@gjsjohnmurray gjsjohnmurray mentioned this issue Nov 3, 2022
Closed
@bvobart bvobart mentioned this issue Nov 24, 2022
Closed
@connor4312 connor4312 added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

proper check for WCO microsoft/vscode
8 participants
@joaomoreno @connor4312 @furai @hediet @edwardchenchen @sbatten @gjsjohnmurray @vscodenpa