Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build Windows stable #165142

Closed
joaomoreno opened this issue Nov 1, 2022 · 0 comments · Fixed by #165143
Closed

Can't build Windows stable #165142

joaomoreno opened this issue Nov 1, 2022 · 0 comments · Fixed by #165143
Assignees
@deepak1556
Labels
candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Milestone
October 2022

Comments

@joaomoreno
Copy link
Member

This is due to #151186
@joaomoreno joaomoreno added vscode-build VS Code build process issues candidate Issue identified as probable candidate for fixing in the next release labels Nov 1, 2022
@joaomoreno joaomoreno added this to the October 2022 milestone Nov 1, 2022
@joaomoreno joaomoreno changed the title Can't build stable Can't build Windows stable Nov 1, 2022
@joaomoreno joaomoreno mentioned this issue Nov 1, 2022
Merged
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
fix inno setup build for non-insider qualities
a193915 
fixes #165142
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
fix inno setup build for non-insider qualities (#165143)
0a19bf0 
fixes #165142
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 1, 2022
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
fix inno setup build for non-insider qualities
119be7d 
fixes #165142
@joaomoreno joaomoreno mentioned this issue Nov 1, 2022
Merged
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
Release port: fix inno setup build for non-insider qualities (#165152)
8fa188b 
fix inno setup build for non-insider qualities

fixes #165142
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

fix inno setup build for non-insider qualities microsoft/vscode
3 participants
@joaomoreno @deepak1556 @vscodenpa