Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: Focus Terminal Tabs view keybinding appears dead/non-working. #163789

Closed
nzwart opened this issue Oct 16, 2022 · 5 comments · Fixed by #164408
Closed

Terminal: Focus Terminal Tabs view keybinding appears dead/non-working. #163789

nzwart opened this issue Oct 16, 2022 · 5 comments · Fixed by #164408
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone

Comments

@nzwart
Copy link

nzwart commented Oct 16, 2022

I'm on macOS 12.6 running VS Code version 1.72.2 (Universal) and after a recent update, the "Terminal: Focus Terminal Tabs View" keybinding won't function.

In short, while focused on the terminal pane, I used to be able to press cmd+shift+\ and move the focus to the Terminal Tabs to the right of the terminal pane (if I had more than one terminal open, which caused the Terminal Tabs to exist).

Now, that keybinding doesn't work anymore, nor does any alternative keybinding for "Terminal: Focus Terminal Tabs".

These are the current when expressions:
"terminalFocus && terminalHasBeenCreated || terminalFocus && terminalProcessSupported || terminalHasBeenCreated && terminalTabsFocus || terminalProcessSupported && terminalTabsFocus"

But removing those when expression entirely or altering them or testing them one at a time does nothing to solve this issue either.

@gjsjohnmurray
Copy link
Contributor

I suggest you check anyterminal.integrated.commandsToSkipShell and terminal.integrated.sendKeybindingsToShell settings.

@nzwart
Copy link
Author

nzwart commented Oct 16, 2022

I just tried enabling terminal.integrated.sendKeybindingsToShell and that didn't change any behavior. I also looked through the default commands in terminal.integrated.commandsToSkipShell and didn't see any that were skipping the Focus on Terminal Tabs view command.

@AHopley
Copy link

AHopley commented Oct 23, 2022

I'm getting the same issue for 1.72.2 on Windows. It isn't just about keybindings. Pressing F1 and doing "Terminal: Focus Terminal Tabs View" moves focus to the active terminal rather than the terminal tabs view. This is true when focus is in the editor, and also if the focus is in the terminal tabs view (which now only seems to be selectable using the mouse).

@nzwart
Copy link
Author

nzwart commented Oct 24, 2022

@AHopley Interesting. I just tried doing what you did with F1 and "Terminal: Focus Terminal Tabs View" in the command palette and had the same behavior. Focusing on the active terminal instead of the terminal tabs view. I also can only select the terminal tabs view with the mouse.

@jeanp413
Copy link
Contributor

This is a regression from #161989, created a PR fixing this #164408

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 3, 2022
@vscodenpa vscodenpa added this to the November 2022 milestone Nov 3, 2022
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Nov 3, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 4, 2022
@andreamah andreamah added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants