Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Maps are wrong #16356

Closed
angelitaooo opened this issue Dec 2, 2016 · 5 comments
Closed

Key Maps are wrong #16356

angelitaooo opened this issue Dec 2, 2016 · 5 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
March 2017

Comments

@angelitaooo
Copy link

  • VSCode Version: 1.7.2 (1.7.2)
  • OS Version: 10.12.1

Steps to Reproduce:

  1. Type CMD + -
    I expect the editor to zoom out but it comments out my code. The editor is mapping the keys in a wrong way.

captura de pantalla 2016-12-01 a las 9 26 23 p m
@angelitaooo
Copy link
Author

Basically, VS Code thinks that my keyboard is an english keyboard for key bindings cmd + anything but works as a regular spanish keyboard for writing code.

@chrmarti
Copy link
Collaborator

chrmarti commented Dec 2, 2016

Related: #16157

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Dec 2, 2016
@alexdima alexdima added the keybindings VS Code keybinding issues label Dec 13, 2016
@alexdima alexdima added the keyboard-layout Keyboard layout issues label Mar 1, 2017
@alexdima alexdima added this to the Backlog milestone Mar 1, 2017
@alexdima alexdima added the macos Issues with VS Code on MAC/OS X label Mar 13, 2017
@alexdima
Copy link
Member

Starting with today's insiders version (i.e. after PR #22894 aka #17521) we have changed how keybinding dispatching works on OSX from using e.keyCode to using e.code (i.e. scan codes).

I have installed the Spanish - ISO keyboard layout i.e.
screen shot 2017-03-24 at 12 41 03

And I have verified that pressing:

  • cmd+shift+7 toggles line comments
  • cmd++ zooms in
  • cmd+- zooms out
    using the default keyboard shortcuts we ship with.

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 24, 2017
@jrieken jrieken added the verified Verification succeeded label Mar 30, 2017
@daniel-keen
Copy link

daniel-keen commented Apr 4, 2017 •
edited
Loading

So... is it going to be fixed some day?

@chrmarti
Copy link
Collaborator

chrmarti commented Apr 4, 2017

It is fixed in the current insiders builds (https://code.visualstudio.com/insiders) and will be fixed in the upcoming stable release.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
5 participants
@jrieken @alexdima @chrmarti @daniel-keen @angelitaooo