JIS (Japanese) Keyboard Layout: Define Keybinding popup window shows wrong key

[ypresto]

• VSCode Version: 1.7.2
• OS Version: macOS Sierra 10.12.1
• Keyboard layout: JIS (Japanese)

Steps to Reproduce:

1. Open keybindings.json
2. Press ⌘K ⌘K
3. Some of key combinations are shown as wrong key

Example of wrong combinations:

Pressed	Expected	Actual
@	@	[
Shift+1	!	Shift+1
Shift+:	*	Shift+'
Shift+Cmd+:	Cmd+*	Shift+Cmd+;

[alexdima]

@ypresto Starting with today's insiders version (i.e. after PR #22894 aka #17521) we have changed how keybinding dispatching works on OSX from using e.keyCode to using e.code (i.e. scan codes).

Can you please download the insider's version and check if we work now correctly (i.e. labels reflect what you press).

In trying to reproduce, I have installed the Japanese keyboard layout on OS X and tried with both Hiragana and Katakana, but for me, the Keyboard Viewer always seem to reflect the US keys, and things appear to be working correctly. Can you perhaps explain in greater detail what steps I need to take to get this OS X system in the same state as yours. e.g. of the Keyboard Viewer:

[ypresto]

My example of Keyboard Viewer:

It reproduces only when I use Japanese IME (even if alphabetical (英字 / eisuu) input is used).
But it does not reproduce when I use U.S. IME.

[ypresto]

Using Keyboard Viewer or hardware key does not change result in my env.

[alexdima]

@ypresto Thanks to the help of @landonepps (through PR microsoft/node-native-keymap#8), I believe we now support Japanese IME on JIS keyboards on OSX a lot better.

Sorry for the constant noise, could you please try again using a more recent VS Code version (I think the fix is also in stable 1.12, but best would be if you could check using the Insiders build)

The reason I am asking is because I only have access to ANSI and ISO keyboards, and not to a JIS keyboard, and OSX sometimes has very different behaviours on the same input method if different physical keyboard types are used.

[landonepps]

@alexandrudima That's great news. I'm currently on vacation without a computer now, but I'll check if it works with a hardware keyboard when I get back.

[landonepps]

I just tested all the listed combinations, and I believe this issue can now be closed.

I'm not sure why @ypresto listed the expected value of shift+1 as !. The currently displayed value shift+1 seems right to me.

: displays as [Quote], and @ displays as [BracketLeft]

This is not ideal, but the program does indicate beneath and in a tooltip that for the current keyboard layout the user should press : and @ respectively. I believe the name Quote and BracketLeft come directly from the results of the macOS function TISGetInputSourceProperty used by node-native-keymap. Since these are the values used by the OS, I think it's acceptable to keep them the same, even though they do not match the physical keyboard keys.

[alexdima]

Thank you @landonepps

Indeed, when a key is ambiguous (i.e. differs from the US keyboard layout), we generate scan code based keybindings, so this is expected.

[ypresto]

I tried insider version:

Wow! It is working like a charm..!! Thank you for fix!