Extra quotes in settings json editor of non-current profile

[alexr00]

Testing #155899

1. Create 2 profiles, A and B.
2. Switch to A. Open the settings.json file for the profile. Keep this file open.
3. Switch to B.
4. Use suggest to modify the value of a setting in A's json file.
5. An extra quote will appear.

[sandy081]

I cannot reproduce it. Anyway this comes from JSON language server.

CC @aeschli

[aeschli]

I'm also not able to reproduce
Did you press shift when selecting the completion (insert mode)?

[alexr00]

No, I just hit enter.

[aeschli]

Can you open the settings and see what editor.suggest.insertMode is configured?
It's default setting is insert but json and jsonc overwrite the default to replace. I wonder if there's some problem with the configuration store.

[alexr00]

It started as an empty profile, so theme is the only thing I have set. Value of editor.suggest.insertMode:

[aeschli]

JSON and JSONC should also be in that list.
I just tested again, switching to a Test profile and I even get even fewer entries:

Looks like there's something off.

[sandy081]

@aeschli Do you think it is related to profiles? If so can you please share any insights on what would have caused it?

[aeschli]

Not clear if it's the settings UI that shows incomplete information, but after switching a profile, not all default language overwrites are shown. If the JSONC language overwrite for editor.suggest.insertMode is not loaded, that would explain what Alex is seeing.

[rzhao271]

I am able to repro the issue and my settings look like #156290 (comment)

[rzhao271]

I'm unable to repro the issue now. I notice when I switch profiles and hover again over the label that it changes the list of languages depending on the extensions installed, but I always manage to have JSON and JSONC in the list.

@alexr00 are you able to repro the issue in the latest Insiders?

[alexr00]

I cannot repro with the latest insiders, though I could still repro with an insiders from some time last week. Looks like it's fixed.