Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick outline should show select item under cursor #154246

Closed
jrieken opened this issue Jul 6, 2022 · 2 comments · Fixed by #154247
Closed

Quick outline should show select item under cursor #154246

jrieken opened this issue Jul 6, 2022 · 2 comments · Fixed by #154247
Assignees
@jrieken
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders outline Source outline view issues quick-open Quick-open issues (search, commands) verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2022

Comments

@jrieken
Copy link
Member

jrieken commented Jul 6, 2022

When quick outline opens and when nothing has been typed it should select the symbol at which the cursor currently is (instead of selecting the very first item)
@jrieken jrieken self-assigned this Jul 6, 2022
@jrieken jrieken added this to the July 2022 milestone Jul 6, 2022
@jrieken jrieken added feature-request Request for new features or functionality outline Source outline view issues quick-open Quick-open issues (search, commands) labels Jul 6, 2022
jrieken added a commit that referenced this issue Jul 6, 2022
@jrieken
select the symbol under cursor when opening quick pick
c3ac074 
fixes #154246
@jrieken jrieken mentioned this issue Jul 6, 2022
Merged
jrieken added a commit that referenced this issue Jul 6, 2022
@jrieken
select the symbol under cursor when opening quick pick (#154247)
01d119a 
fixes #154246
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 6, 2022
jrieken added a commit that referenced this issue Jul 7, 2022
@jrieken
focus last (not first) symbol enclosing position, refines #154246
afba190
jrieken added a commit that referenced this issue Jul 7, 2022
@jrieken
focus last (not first) symbol enclosing position, refines #154246 (#1…
7efebe8 
…54340)
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 8, 2022
@kieferrm kieferrm mentioned this issue Jul 11, 2022
Closed
98 tasks
@alexdima
Copy link
Member

Nice! ❤️

@jrieken jrieken added the verification-needed Verification of issue is requested label Jul 21, 2022
@jrieken
Copy link
Member Author

jrieken commented Jul 21, 2022

To verify:

  • open a TS file
  • put your cursor into a function or method
  • trigger quick outline (cmd+shift+o)
  • verify that the symbol in which the cursor is is selected

@sandy081 sandy081 added the verified Verification succeeded label Jul 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders outline Source outline view issues quick-open Quick-open issues (search, commands) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

select the symbol under cursor when opening quick pick microsoft/vscode
4 participants
@jrieken @alexdima @sandy081 @vscodenpa