Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background tasks should drop their terminal status when they exit #152141

Closed
Tyriar opened this issue Jun 15, 2022 · 2 comments · Fixed by #153337
Closed

Background tasks should drop their terminal status when they exit #152141

Tyriar opened this issue Jun 15, 2022 · 2 comments · Fixed by #153337
Assignees
@Tyriar @meganrogge @alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Milestone
June 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2022

This situation below confuses me sometimes as it looks like the watch task is well and good but it actually exited with a code of 0:

Screen Shot 2022-06-14 at 7 18 39 pm

I think the better behavior is to show the failure status if the exit code is non-zero and remove the status if the exit code is 0.
@Tyriar Tyriar added the tasks Task system issues label Jun 15, 2022
@alexr00
Copy link
Member

alexr00 commented Jun 15, 2022

Makes sense!

@Tyriar Tyriar added the feature-request Request for new features or functionality label Jun 15, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 15, 2022
meganrogge added a commit that referenced this issue Jun 27, 2022
@meganrogge
fix #152141
7ca1607
@meganrogge meganrogge mentioned this issue Jun 27, 2022
Merged
meganrogge added a commit that referenced this issue Jun 27, 2022
@meganrogge
drop status for background tasks when process exits (#153337)
89864bb 
fix #152141
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 27, 2022
@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2022
@meganrogge
Copy link
Contributor

adding bug so it gets verified

to verify,

run a background task (like VS Code build) and press ctrl c in the task terminal(s). You should not see a checkmark after the process exit statement is displayed in the terminal

@meganrogge meganrogge removed the feature-request Request for new features or functionality label Jun 27, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2022
@Tyriar Tyriar added the verified Verification succeeded label Jun 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

drop status for background tasks when process exits microsoft/vscode
4 participants
@Tyriar @meganrogge @alexr00 @vscodenpa