Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flooding npm with @types package requests #14889

Closed
chrmarti opened this issue Nov 2, 2016 · 4 comments
Closed

Flooding npm with @types package requests #14889

chrmarti opened this issue Nov 2, 2016 · 4 comments
Assignees
@seanmcbreen @dbaeumer @kieferrm
Labels
important Issue identified as high-priority

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Nov 2, 2016

  • VSCode Version: 1.7.0

Reported by npm folks. Seems to be triggered by the automatic type acquisition in TS.
@chrmarti chrmarti added the important Issue identified as high-priority label Nov 3, 2016
chrmarti added a commit that referenced this issue Nov 3, 2016
@chrmarti
Turn off automatic type acquisition (#14889)
692795d
@chrmarti chrmarti mentioned this issue Nov 3, 2016
Closed
@chrmarti chrmarti assigned seanmcbreen and kieferrm and unassigned chrmarti Nov 3, 2016
@seldo
Copy link

seldo commented Nov 3, 2016

I gave a response from npm over on HN, and rather than duplicate it I'll just link: https://news.ycombinator.com/item?id=12861093

@dbaeumer
Copy link
Member

dbaeumer commented Nov 3, 2016

@chrmarti we discussed this in the meeting today and before we don't have a fix in the tsserver available we decided to turn off ATA completely. That means users can't turn it on to avoid that too many users for enable it and cause another round of problems.

dbaeumer added a commit that referenced this issue Nov 3, 2016
@dbaeumer
Fixes #14889: Flooding npm with @types package requests
b3c1027
@kevinSuttle
Copy link

Outstanding response to this, Code team.

In the interim, is it possible to ship a build with everything in 1.7 excluding the Intellisense issue?

@weinand
Copy link
Contributor

weinand commented Nov 3, 2016

@kevinSuttle a 1.7.1 build is in preparation...

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seanmcbreen seanmcbreen

@dbaeumer dbaeumer

@kieferrm kieferrm

Labels
important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevinSuttle @seldo @seanmcbreen @weinand @dbaeumer @kieferrm @chrmarti