Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline the sync warning dialog #145988

Closed
digitarald opened this issue Mar 24, 2022 · 3 comments
Closed

Streamline the sync warning dialog #145988

digitarald opened this issue Mar 24, 2022 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@digitarald
Copy link
Contributor

Testing #145525:

image

is a lot to read and click on, especially for new users that don't understand how vscode.dev works. Three 1-liner paragraphs and 4 buttons to pick from. A shorter form could be friendlier and more guiding:

Quick idea: "VS Code for Web could not open latest content from {repository}, as your last session had uncommited changes in {package.json | 2 files}. We recommend to sync the {18} new commits to keep your changes."

@digitarald digitarald added the polish Cleanup and polish issue label Mar 24, 2022
@joyceerhl
Copy link
Collaborator

This dialog can only appear for users who have already viewed and edited a repo, so you wouldn't see this when just getting started.

I dropped the Discard Changes action: #145695 (comment)

Thoughts on this language?:
image

@digitarald
Copy link
Contributor Author

I am torn on "auto-syncing". Do we use it anywhere else? First time I read it sounded like any changes are auto-saved to github, like auto-commit. Maybe it works, but it would be good if we use it consistently (maybe also in the SCM info tooltip). In the sentence it now mixes "auto-sync", "uncommited", and "commit behind" behind.

If we go with "auto-syncing", "continue without sync" could also adopt the "auto-sync" language. "Keep auto-syncing paused".

@joyceerhl
Copy link
Collaborator

We ended up removing the 'auto syncing' language in this dialog and reduced the number of actions shown to 3, thus closing this item.

@joyceerhl joyceerhl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@joyceerhl joyceerhl added *duplicate Issue identified as a duplicate of another issue(s) and removed polish Cleanup and polish issue labels Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants