Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: dialog warning of stale repository due to uncommitted changes in RemoteHub #145525

Closed
2 tasks done
joyceerhl opened this issue Mar 21, 2022 · 0 comments
Closed
2 tasks done

Comments

@joyceerhl
Copy link
Collaborator

joyceerhl commented Mar 21, 2022

Refs: microsoft/vscode-remote-repositories-github#115

Complexity: 2

Create Issue


This milestone we explored introducing a dialog to RemoteHub workspaces which alerts the user when they may be viewing an outdated version of their repository and guides them to sync their repository state before proceeding to work with their repository. Typically, RemoteHub users are shown the latest version of their repositories, but when users leave uncommitted changes in their repository, RemoteHub does not perform an automatic sync, since syncing can introduce merge conflicts.

Please test the following behavior:

  1. Open insiders.vscode.dev to a GitHub repository
  2. Make some edits to a file
  3. From github.dev, commit to the same repo
  4. Reload the insiders.vscode.dev tab
  5. By default you should see a modal dialog highlighting that you have uncommitted changes in insiders.vscode.dev and are some commits behind
  6. Test that the four actions "Sync", "Discard Changes", "Continue Without Syncing", and "Don't Show Again" behave as expected

The modal dialog is controlled by a setting: remoteHub.experimental.uncommittedChangesOnEntry. In pre-releases of RemoteHub, this setting defaults to promptIfBehind. Please test the following setting values and ensure they behave as expected:
a. promptIfBehind
- You should see a modal dialog only when you enter a workspace with uncommitted changes and have commits made to the current branch that have not yet been pulled
- You should not see a modal dialog when you enter a workspace with uncommitted changes that is up to date with the remote
b. promptAlways
- You should see a modal dialog when you enter a workspace with uncommitted changes, whether you are up to date with the remote or not
c. none
- You should never see a modal dialog even when you have uncommitted changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants