-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a terminal in an empty restricted window #141463
Comments
In this case, it definitely gets in the way that we ask about trust, and also doesn't make too much to limit access to the terminal. However, what considerations should be in place for when someone decides to bring in untrusted content into the workspace after the terminal is opened? Does this matter for empty workspaces @Tyriar? |
@sbatten it's only useful for the terminal if the folder is of a potentially foreign origin. I could special case this since it's going to open in the home directory anyway, but should it even be possible to have an empty window in restricted mode? Might need to handle this special case in multiple places if it's not handled by the trust request service? |
we have settings to configure the empty window experience... this allows empty windows to bring in untrusted content easily without prompting. |
Ok, let's allow opening the terminal if the active workspace root is undefined then as it's safe in that case. |
It's an edge case but worthwhile considering
-> prompt for trusting the workspace, but there is nothing there to be trusted
The text was updated successfully, but these errors were encountered: