Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable path IntelliSense in markdown #140602

Closed
mjbvz opened this issue Jan 13, 2022 · 3 comments
Closed

Enable path IntelliSense in markdown #140602

mjbvz opened this issue Jan 13, 2022 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues on-testplan
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 13, 2022

Tracks enabling simple path intellisense inside of markdown files, specifically when completing links

Goals

  • Support path suggestions to other files
  • Support suggestions to header sections in the current file
  • Support completions for [](path) style links as well as reference links: [][ref]
  • Support relative links (path/to/file or ./path/to/file) and absolute links (/path/to/file)
  • Setting to easily disable this feature

Out of scope

  • Suggestions for shorthand reference links such as [bla] (could be added in the future)
  • Path intellisense for html inside markdown
  • file:// uris
@mjbvz mjbvz added feature-request Request for new features or functionality markdown Markdown support issues labels Jan 13, 2022
@mjbvz mjbvz added this to the January 2022 milestone Jan 13, 2022
@mjbvz mjbvz self-assigned this Jan 13, 2022
@mjbvz mjbvz changed the title Enable IntelliSense in markdown Enable path IntelliSense in markdown Jan 13, 2022
mjbvz added a commit that referenced this issue Jan 13, 2022
For #140602

Only normal links for now. Will add reference links later. Should support the forms:

- `[](dir/file.md)`
- `[](./dir/file.md)`
- `[](/root-dir/file.md)`
- `[](#header)`
- `[](./dir/file.md#header)`
@ArturoDent
Copy link

ArturoDent commented Jan 13, 2022

Is this in the Insiders Build yet? I don't see the setting markdown.suggest.paths.enabled and the path intellisense doesn't seem to do anything yet. [trying to test it]

Version: 1.64.0-insider (user setup)
Commit: 753319a
Date: 2022-01-12T05:16:42.486Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

@karlhorky
Copy link

karlhorky commented Feb 4, 2022

@mjbvz this is amazing, thanks!! 🙌

What would be necessary to enable this also for MDX files? This is something that a few people have been asking for, for a while now:

If it's a valid question and it should have another issue, happy to open a new issue for this!

@karlhorky
Copy link

karlhorky commented Feb 4, 2022

Oh, one other thing: now that there's IntelliSense in Markdown files, is it possible to also have this in attributes for HTML in those files?

Eg. in the src of the <img> tag here?

Screen Shot 2022-02-04 at 19 36 24

Would also open another issue for this, if it's a valid request.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues on-testplan
Projects
None yet
Development

No branches or pull requests

5 participants
@karlhorky @hediet @mjbvz @ArturoDent and others