Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor.hover.delay has an undocumented maximum value of 10000 #140215

Closed
gjsjohnmurray opened this issue Jan 6, 2022 · 2 comments · Fixed by #140216
Closed

editor.hover.delay has an undocumented maximum value of 10000 #140215

gjsjohnmurray opened this issue Jan 6, 2022 · 2 comments · Fixed by #140216
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
January 2022

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

Increasing editor.hover.delay above 10000 has no effect.

See

vscode/src/vs/editor/common/config/editorOptions.ts

Line 1871 in 0c93312

delay: EditorIntOption.clampedInt(input.delay, this.defaultValue.delay, 0, 10000),

VS Code version: Code - Insiders 1.64.0-insider (9afbea7, 2022-01-06T05:15:07.481Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
@gjsjohnmurray
Copy link
Contributor Author

Found when reporting #140212

I will submit a PR

gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Jan 6, 2022
@gjsjohnmurray
Surface the maximum and minimum values for editor.hover.delay (fixes …
d3942e1 
…microsoft#140215)
@gjsjohnmurray gjsjohnmurray mentioned this issue Jan 6, 2022
Merged
@gjsjohnmurray
Copy link
Contributor Author

/assign @alexdima

alexdima added a commit that referenced this issue Jan 11, 2022
@alexdima
Merge pull request #140216 from gjsjohnmurray/fix-140215
49d54c9 
Surface the maximum and minimum values for `editor.hover.delay` (#140215)
@alexdima alexdima added this to the January 2022 milestone Jan 11, 2022
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover labels Jan 11, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

Surface the maximum and minimum values for editor.hover.delay (#140215) gjsjohnmurray/vscode
4 participants
@alexdima @gjsjohnmurray @rzhao271 and others