Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up notebook CSS #140133

Open
2 tasks
roblourens opened this issue Jan 4, 2022 · 1 comment
Open
2 tasks

Clean up notebook CSS #140133

roblourens opened this issue Jan 4, 2022 · 1 comment
Assignees
@roblourens
Labels
notebook-rendering polish Cleanup and polish issue
Milestone
On Deck

Comments

@roblourens
Copy link
Member

  • Break up notebook.css into parts corresponding to CellParts
  • Move dynamic styles into real css files, with css variables for the layout parameters
@roblourens roblourens added this to the January 2022 milestone Jan 4, 2022
@roblourens roblourens mentioned this issue Jan 4, 2022
Closed
4 tasks
@rebornix rebornix modified the milestones: January 2022, February 2022 Jan 27, 2022
@rebornix rebornix modified the milestones: February 2022, March 2022 Feb 23, 2022
@rebornix rebornix modified the milestones: March 2022, On Deck Mar 23, 2022
rebornix added a commit that referenced this issue Dec 30, 2022
@rebornix
Re #140133. Separate cell part css
e0d886b
@rebornix
Copy link
Member

Moved more into cell part specific css through #170260 and we have already moved a lot of css rules to variables last month.

@rebornix rebornix removed their assignment Dec 30, 2022
rebornix added a commit that referenced this issue Dec 30, 2022
@rebornix
Re #140133. Separate cell part css (#170260)
257533b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
notebook-rendering polish Cleanup and polish issue
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
5 participants
@roblourens @rebornix @amunger @greazer and others