-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visually distinguish fixes from non-fixes in lightbulb menu #132109
Comments
…t#132109) * added disabled hover * code cleanup on disabled option hovers * removed comments * widget enabled by default * code cleanup and fix on build * clean up on css removed unused importants * small patch for css rules * minor refactor on codeactionitems * fix on disabled option click * fix on disabled option click * added some icons but just temp * added iconws and modified widget look * added beginning logic for menu groupings * looks pretty good for a menu wooo * added headers to menu + removed extra text from option labels * minor code cleanup on group filtering * Refactoring on code action kind * changed styling based on feedback * code cleanup * First couple of fixes on PR for code action kinds * modified icons and refactoring * removed extra push * removed parsing and added code action kind for surround
Hey I just tried out the new menu in insiders and it looks great! I was wondering if you would consider adding 2 code action classes that are I think quite common:
This would be super valuable for the extension that I'm developing (P42 JavaScript Assistant), but I think also for other extensions. Afaik the TS language server also has |
@lgrammel Do you think you can provide examples of inline and move options and what those labels say? ATM, I know there is a |
@justschen Here are some examples from "Refactoring, 2nd Edition" (Fowler) that could be relevant for language services from different languages: Inline:
Move:
I would also consider "Pull Up / Push Down" refactorings to be "move" refactorings, e.g. "Pull Up Field". P42 has several inline refactorings:
and many move refactorings, e.g.
|
When invoking the lightbulb menu on an error, the menu can include a mix of both fixes and non-fixes (eg. refactors) mixed together:
It would be good if there was some visual separation or indication of which of these are fixes for the diagnostic and which are not. For example in Android Studio I see the fixes have lightbulbs and non-fixes have pencil/edit icons:
The text was updated successfully, but these errors were encountered: