Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable keepScrollPosition: boolean in quickpick API #132068

Closed
TylerLeonhardt opened this issue Sep 1, 2021 · 4 comments
Closed

Enable keepScrollPosition: boolean in quickpick API #132068

TylerLeonhardt opened this issue Sep 1, 2021 · 4 comments
Assignees
@TylerLeonhardt
Labels
api-finalization feature-request Request for new features or functionality on-testplan quick-pick Quick-pick widget issues
Milestone
November 2021

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Sep 1, 2021 •
edited
Loading

Continuing from #109969 which is fixed in Core in #132013, I'd like to expose that property to the API:

keepScrollPosition: boolean

It's a property on quickpick that is similar to ignoreFocusOut: boolean and it would specifically handle the behavior of what to do with the scroll position when items or activeItems are changed.
@TylerLeonhardt TylerLeonhardt self-assigned this Sep 1, 2021
@TylerLeonhardt TylerLeonhardt added api-proposal feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Sep 1, 2021
@TylerLeonhardt TylerLeonhardt added this to the September 2021 milestone Sep 1, 2021
TylerLeonhardt added a commit that referenced this issue Sep 1, 2021
@TylerLeonhardt
adds a proposed API for keeping scroll position. ref #132068
ab8955c
@TylerLeonhardt
Copy link
Member Author

I've added this in ab8955c as a proposed API

This was referenced Sep 1, 2021
Closed
Closed
@TylerLeonhardt
Copy link
Member Author

I will finalize this in Oct.

@TylerLeonhardt
Copy link
Member Author

closing this so it's on endgame for Sept and then will reopen for Oct.

@TylerLeonhardt TylerLeonhardt mentioned this issue Sep 27, 2021
Closed
2 tasks
@TylerLeonhardt TylerLeonhardt reopened this Oct 4, 2021
@TylerLeonhardt
Copy link
Member Author

Finalized in f8ed49c

@TylerLeonhardt TylerLeonhardt mentioned this issue Nov 23, 2021
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
api-finalization feature-request Request for new features or functionality on-testplan quick-pick Quick-pick widget issues
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
1 participant
@TylerLeonhardt