Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/Prev Group should not create new group #12833

Closed
octref opened this issue Sep 27, 2016 · 4 comments
Closed

Next/Prev Group should not create new group #12833

octref opened this issue Sep 27, 2016 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Sep 27, 2016

  • VSCode Version: 1.6.0
  • OS Version: OS X 10.11.6

Currently if you have group 1 & 2 and is on 2, Go -> Switch Group -> Next Group will create Group 3. Instead it should go to group 1.

If you have group 1, 2 & 3 and focus is on 3, Go -> Switch Group -> Next Group will do nothing. It should go to group 1, too.

@bpasero bpasero added feature-request Request for new features or functionality workbench labels Sep 28, 2016
@bpasero
Copy link
Member

bpasero commented Sep 28, 2016

I think we should not change the behaviour you mention first, but the latter can be done I think.

Sounds like a good area for a Pull Request.

@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Sep 28, 2016
@octref octref self-assigned this Sep 28, 2016
@octref
Copy link
Contributor Author

octref commented Oct 7, 2016

Currently when you have Group 1 & 2 & 3 and is on 1, running Prev Group does nothing. I can also make it go 3.
But if you have Group 1 & 2 and is on 1, should Prev Group create 3 and go to 3, or just go to 2?

@hun1ahpu
Copy link
Contributor

@bpasero: Both Sublime and Atom do not add new Group on Next/Prev but just circle through existing ones. It kind of makes sense.

bpasero added a commit that referenced this issue Dec 21, 2016
@bpasero bpasero changed the title Next/Prev Group should go circles and not create new group Next/Prev Group should not create new group Jan 4, 2017
@thiagoh
Copy link

thiagoh commented Jun 2, 2017

Any updates on this issue, by chance? I mean, it's really boring have to close the group when you're on group 2 and then triggers move to next group and it creates a new group.. I think it should circle back to group 1 (if there is no group 3 already, obviously)

@bpasero bpasero added this to the June 2017 milestone Jun 3, 2017
@bpasero bpasero self-assigned this Jun 3, 2017
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Jun 6, 2017
@bpasero bpasero closed this as completed Jun 6, 2017
@bpasero bpasero added the verification-needed Verification of issue is requested label Jun 13, 2017
@isidorn isidorn added the verified Verification succeeded label Jun 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants