Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make suggest widget inherit editor.letterSpacing #125622

Closed
alexdreptu opened this issue Jun 6, 2021 · 3 comments · Fixed by #148283
Closed

Make suggest widget inherit editor.letterSpacing #125622

alexdreptu opened this issue Jun 6, 2021 · 3 comments · Fixed by #148283
Assignees
@jrieken
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders suggest IntelliSense, Auto Complete ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2022

Comments

@alexdreptu
Copy link

I set my editor.letterSpacing on negative to make the font more condensed, but the suggest widget doesn't inherit the value and the text looks wider than the editor text, which depending on the font also makes it look uglier. I would like to be able to make the font look the same in both.
@jrieken jrieken added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities suggest IntelliSense, Auto Complete ux User experience issues labels Jun 7, 2021
@jrieken jrieken added this to the Backlog milestone Jun 7, 2021
@hediet hediet mentioned this issue Jun 8, 2021
Closed
@barisunsalhn

This comment has been minimized.

Sign in to view
eugenesimakin added a commit to eugenesimakin/vscode that referenced this issue Apr 27, 2022
@eugenesimakin
Inherit editor.letterSpacing for suggest widget (fixes microsoft#125622)
fce4175
@eugenesimakin eugenesimakin mentioned this issue Apr 27, 2022
Merged
@eugenesimakin
Copy link
Contributor

Hi folks,

I created a pull request for this. Hope it helps.
Please, review it.

Thanks.

@jrieken jrieken modified the milestones: Backlog, May 2022 May 4, 2022
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Jun 1, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 1, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Jun 1, 2022 •
edited
Loading

I'm wondering why the suggestions seem cut off at the end?
I have "editor.letterSpacing": -2

Screenshot showing that some suggestion text is clipped at the end

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders suggest IntelliSense, Auto Complete ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Inherit editor.letterSpacing for suggest widget (fixes #125622) eugenesimakin/vscode
7 participants
@joaomoreno @jrieken @eugenesimakin @alexdreptu @rzhao271 @barisunsalhn and others