Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single terminal tab doesn't show when killing terminal via action #122187

Closed
Tyriar opened this issue Apr 26, 2021 · 0 comments
Closed

Single terminal tab doesn't show when killing terminal via action #122187

Tyriar opened this issue Apr 26, 2021 · 0 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Milestone
April 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 26, 2021 •
edited
Loading

Reported in #120241 (comment)

Repro:

  1. Split via the single tab
  2. Kill via the hover action

116054665-30370600-a67c-11eb-8066-54846ad5eb22
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-tabs labels Apr 26, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 26, 2021
@Tyriar Tyriar mentioned this issue Apr 26, 2021
Closed
36 tasks
@Tyriar Tyriar closed this as completed in acc4bce Apr 26, 2021
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Apr 26, 2021
@Tyriar @gjsjohnmurray
Adjust active instance in tab on dispose
9f266fd 
Fixes microsoft#122187
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-tabs verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
4 participants
@Tyriar @rzhao271 @meganrogge and others