Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux Snap package startup speed #117852

Closed
Hans03430 opened this issue Feb 28, 2021 · 6 comments · Fixed by #118116 or #119478
Closed

Linux Snap package startup speed #117852

Hans03430 opened this issue Feb 28, 2021 · 6 comments · Fixed by #118116 or #119478
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug on-release-notes Issue/pull request mentioned in release notes snap Issues related to the snap package verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone
March 2021

Comments

@Hans03430
Copy link

Hello, are there any plans to use the LZO compression inside the snapcraft.yaml file in order to improve the startup speed of VS Code when installed as a Snap in Linux?
@joaomoreno
Copy link
Member

There is currently no feature work planned for the snap package.

soredake added a commit to soredake/vscode that referenced this issue Mar 4, 2021
@soredake
snap: set compression to lzo, microsoft#117852
3ddac3a
@soredake soredake mentioned this issue Mar 4, 2021
Merged
joaomoreno pushed a commit that referenced this issue Mar 8, 2021
@soredake
snap: set compression to lzo, #117852 (#118116)
e22c2be
@bpasero bpasero added this to the March 2021 milestone Mar 8, 2021
RMacfarlane pushed a commit that referenced this issue Mar 9, 2021
Revert "snap: set compression to lzo, #117852 (#118116)"
79e2119 
This reverts commit e22c2be.
soredake added a commit to soredake/vscode that referenced this issue Mar 16, 2021
@soredake
snap: set compression to lzo, again, microsoft#117852
c969e5c
@anonymouse64 anonymouse64 mentioned this issue Mar 22, 2021
Merged
@joaomoreno joaomoreno added snap Issues related to the snap package bug Issue identified by VS Code Team member as probable bug on-release-notes Issue/pull request mentioned in release notes labels Mar 24, 2021
@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Mar 26, 2021
@roblourens
Copy link
Member

What needs to be verified exactly?

@joaomoreno
Copy link
Member

joaomoreno commented Mar 29, 2021 •
edited
Loading

Verification

Download our snap package and make sure it has lzo compression.

$ unsquashfs -s code-insider-x64-*.snap | grep Compression
Compression lzo

@Hans03430
Copy link
Author

Hello. I don't know where to download the .snap file but I installed Visual Code Insiders from the Snapcraft store and I can confirm that the startup speed of the Insiders version is far faster than the non Insiders one. VS Code Insiders cold starts in a second while the non Insider version takes far longer.

@joaomoreno
Copy link
Member

Here's the latest snap package: https://az764295.vo.msecnd.net/insider/26a60dbecacc8bdacc06f7681ebe95398878a1cd/code-insider-x64-1617014928.snap

@Hans03430
Copy link
Author

xxx@xxxxx:~/Descargas$ unsquashfs -s code-insider-x64-*.snap | grep Compression
Compression lzo

I can confirm that the package says it has lzo compression after running that command.

@joaomoreno joaomoreno added the verified Verification succeeded label Mar 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug on-release-notes Issue/pull request mentioned in release notes snap Issues related to the snap package verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Milestone
March 2021
4 participants
@joaomoreno @roblourens @bpasero @Hans03430